Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entity parsing #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

andresmanelli
Copy link

This PR adds entity parsing, at least basically.

Should help/fix #13 and #6 ?

@andresmanelli
Copy link
Author

Well, I added a small commit for ports and generics default values

@m-tosch
Copy link

m-tosch commented May 18, 2020

Regarding issue #13, this only fixed the entity. If you can, change the "architecture" and "package" parts too :)

@andresmanelli
Copy link
Author

Hey @m-tosch, almost a year after your comment, I created #19 . I'm not 100 % sure if those work perfectly fine. Could you try it out ? That way this PR can be merged maybe alonside #19 to fix #13

Thanks !

@m-tosch
Copy link

m-tosch commented May 27, 2021

The matching should be done as for "entity" using just \w+ i think that's best

(r'end\s+\w+\s*;', 'end_entity', '#pop'),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

matching end of entity and end of architecture
2 participants