Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: also take in account the description of the PR #11

Closed
1 task done
nadavsinai-philips opened this issue Feb 4, 2024 · 1 comment
Closed
1 task done

feat: also take in account the description of the PR #11

nadavsinai-philips opened this issue Feb 4, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@nadavsinai-philips
Copy link

Is there an existing request for this?

  • I have searched the existing feature requests

Is the feature request related to a problem?

yes, prlint will only get the title of the PR

Is the feature request related to a existing bug/RFC?

No response

Describe the solution you'd like

I implemented the fix in my fork. so would like to discuss if you'd want a PR.

What is the definition of done?

PR is being linted with both title and description being taken in to account, not a breaking change to API

Any solutions considered?

No response

Are you able to assist to bring the feature to reality?

Yes, I can

Anything else?

In my fork, I also removed the ESM translation feature, I have some js, and some JSON configs and this would not work well with the way you implemented the translation so removed this complexity, I think this is no longer relvant anymore, people can just use .mjs for module syntax

@nadavsinai-philips nadavsinai-philips added the enhancement New feature or request label Feb 4, 2024
@nadavsinai-philips nadavsinai-philips changed the title feat: also use the description of the pr feat: also use the description of the PR Feb 4, 2024
@nadavsinai-philips nadavsinai-philips changed the title feat: also use the description of the PR feat: also take in account the description of the PR Feb 4, 2024
@kevintyj
Copy link
Owner

@nadavsinai-philips Oh wow! this looks really useful! Thanks for the fork and also the work on the source code, I do agree with your comment on ESM conversion, that had to be done because of some of our internal company pipelines. As we move away from our old pipeline and actually committed to full ESM migration, I am thinking of dropping CJS support in the upcoming release. I do not know how many people are actually using this action, but I plan on adding CJS support back in the future with a much more elegant solution than the string replacement thats being done right now. Since v9 of commitment also add pure ESM, this would also be handy as well. I am looking to push updates to this action in the coming weeks as our company changes pipeline! Feel free to raise any additional FR or PRs <3

@kevintyj kevintyj self-assigned this Jun 23, 2024
@kevintyj kevintyj closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants