-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate to v9 #13
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
===========================================
- Coverage 100.00% 98.83% -1.17%
===========================================
Files 4 4
Lines 123 172 +49
Branches 23 28 +5
===========================================
+ Hits 123 170 +47
- Misses 0 2 +2 ☔ View full report in Codecov by Sentry. |
5684442
to
a633b2d
Compare
13faa99
to
6c41a76
Compare
Welp that was a nice try... Edit: I may have over engineered the solution from the beginning, with all of the dependencies like ncc, cosmiconfig, v19 commitlint update, esm <-> cjs backwards compatibility, and a lot of other minor issues added a lot of unwanted complexity to the problem. The problem being why I had to be the one trying to parse the configuration file when there already are built in exported functions. Solution:
Thats it. But to be honest, it was kind of the only feature as well... so... I came up with a compromise, which I genuinely think is a better solution:
I will try to implement these features in the upcoming days will start raising new PRs |
Migrates commitment to v9 (ESM support migration)
BREAKING!: Drops CJS support (will try to add CJS support again later)