Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for multiple TYPE parameters #388

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Adds support for multiple TYPE parameters #388

merged 1 commit into from
Jan 13, 2020

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Apr 5, 2019

Fixes #343.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 96.928% when pulling c88e15c on caugner:343-vcard-multiple-types into 2b4e50d on mozilla-comm:master.

@coveralls
Copy link

coveralls commented Apr 6, 2019

Coverage Status

Coverage increased (+0.005%) to 96.986% when pulling a191c50 on caugner:343-vcard-multiple-types into 756f351 on mozilla-comm:master.

@caugner
Copy link
Contributor Author

caugner commented Oct 31, 2019

@kewisch Should I resolve the conflicts (by rebuilding) or will you do this anyway before merging?

PS: Maybe this could be automatised via Travis.

@giddyhup
Copy link

I made this issue my start page. How many trees may I plant to get the fix implemented?

@Nemental
Copy link

@giddyhup I feel you! :D

@giddyhup
Copy link

@kewisch please include this!

@kewisch
Copy link
Owner

kewisch commented Jan 13, 2020

This looks good, thanks so much! I've added another test for iCalendar. I'm not sure if it is technically allowed to have multiple parameters there, but at least we'd be able to read them.

@kewisch kewisch merged commit 64d06d9 into kewisch:master Jan 13, 2020
@kewisch
Copy link
Owner

kewisch commented Jan 13, 2020

I made this issue my start page. How many trees may I plant to get the fix implemented?

I hope you planted a lot of trees. If so, not getting around to this may have been my easiest contribution to save the planet yet ;-)

@giddyhup
Copy link

grafik

https://teamtrees.org/#recent-donations
@kewisch

@caugner caugner deleted the 343-vcard-multiple-types branch January 13, 2020 16:07
@caugner
Copy link
Contributor Author

caugner commented Jan 13, 2020

@kewisch

I'm not sure if it is technically allowed to have multiple parameters there

Thanks for merging. Indeed it is allowed:

grafik

Source: https://tools.ietf.org/html/rfc6350#section-6.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vCard: Parse multiple types
6 participants