Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to ES6 modules #538

Merged
merged 22 commits into from
Oct 14, 2022
Merged

Adapt to ES6 modules #538

merged 22 commits into from
Oct 14, 2022

Conversation

kewisch
Copy link
Owner

@kewisch kewisch commented Sep 19, 2022

Hey @darktrojan @leftmostcat @metasansana Here is my ES6 adaption of the library. I'd love to get this merged before we do any other major work, rebasing just the few changesets was a pain an prone to failure. I can help adapt pending PRs afterwards.

With the amount of changes you'll have to see how much review is useful, be sure to ignore whitespaces while reviewing, it will save you about 5k lines and makes reading easier!

docs/validator.html Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Sep 19, 2022

Pull Request Test Coverage Report for Build 3253589896

  • 7754 of 7879 (98.41%) changed or added relevant lines in 20 files are covered.
  • 28 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+2.7%) to 98.137%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ical/parse.js 472 474 99.58%
lib/ical/time.js 1075 1078 99.72%
lib/ical/timezone.js 436 440 99.09%
lib/ical/recur_expansion.js 390 398 97.99%
lib/ical/recur_iterator.js 1001 1109 90.26%
Files with Coverage Reduction New Missed Lines %
lib/ical/recur_expansion.js 3 97.22%
lib/ical/recur_iterator.js 25 89.41%
Totals Coverage Status
Change from base Build 3012316465: 2.7%
Covered Lines: 9201
Relevant Lines: 9360

💛 - Coveralls

package.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@darktrojan darktrojan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't got the available time or sanity to go through this line by line, but I've scanned through it and pointed out the things that stood out. I didn't really take much notice of changes outside lib and test as others have already had a look and TBH they probably know more about those things than I do.

As long as the tests pass and you pick up the missing bit of stringify.property I found then I approve. It would be useful if you put this into Thunderbird (even hacking it in temporarily) and ran the tests there, including the address book tests that handle vCards.

lib/ical/recur_iterator.js Outdated Show resolved Hide resolved
lib/ical/stringify.js Outdated Show resolved Hide resolved
@kewisch
Copy link
Owner Author

kewisch commented Oct 14, 2022

It would be useful if you put this into Thunderbird (even hacking it in temporarily) and ran the tests there, including the address book tests that handle vCards.

I was much hoping someone from the team could test this in Thunderbird, I don't have the setup currently so it would take me a bit to get back into the groove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants