Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change EventHeader to EventHeaderName #240

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Change EventHeader to EventHeaderName #240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/edm4hep/Constants.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

namespace edm4hep {
static constexpr const char* CellIDEncoding = "CellIDEncoding";
static constexpr const char* EventHeader = "EventHeader";
static constexpr const char* EventHeaderName = "EventHeader";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
static constexpr const char* EventHeaderName = "EventHeader";
static constexpr const char* eventHeader = "EventHeader";

As a "less-typing necessary" variant? Or maybe EvtHeader?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer clarity over shortness

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all for typing less 🤓 but in this case a mistake from eventHeader to EventHeader can even make the code compile and have some problems somewhere else and EvtHeader is also quite similar. I was going to say let Leonhard decide, but he beat me to it so it's two votes against one. I checked the CI failure and I'm quite sure it's not transient, but it's unrelated. I'll have a look and try to fix it

} // namespace edm4hep

#endif // EDM4HEP_CONSTANTS_H
Loading