-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add read tests to ensure backwards compatibility #358
Conversation
d3b4133
to
7753c39
Compare
I have created the necessary directory on eos to upload files and added the CMake infrastructure to fetch them via the Maybe this PR needs to be split into two parts, to make it possible to create a tag in between, so that the parts with the backwards compatibility can work off of well defined versions. |
6bbac97
to
18868ed
Compare
18868ed
to
6162a88
Compare
I will upload new files once we have tags for EDM4hep and podio, then the checks should pass. I don't foresee any more code changes now, unless there are comments from reviewing it. |
3ad2b03
to
ef22c50
Compare
I have added newly produced files (from podio and EDM4hep master / main branches), to verify that things work if both are at their current head. After both have been tagged, I will upload files produced with the actually tagged version and update this accordingly. |
427e6d0
to
2d62fb8
Compare
Input files from tagged podio and EDM4hep have been uploaded and are now used for the tests. The old files from intermediate testing have been removed again. |
The gaudi_fixtures that have been introduced with v39 include the full python file otherwise, which matches the FAIL_REGULAR_EXPRESSION and makes the test fail even though they are actually passing
2d62fb8
to
951d5f6
Compare
Following this comment, I have added Unless someone wants to still have a look and comment, I would merge this either later today or early tomorrow. |
@tmadlener - what's the issue with the failing test on the downstream-build ? |
That seems to be an unrelated test failure in k4SimDelphes. Looks like it has been failing there as well. I will have a look. |
BEGINRELEASENOTES
ENDRELEASENOTES