Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read tests to ensure backwards compatibility #358

Merged
merged 7 commits into from
Sep 26, 2024

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Sep 6, 2024

BEGINRELEASENOTES

  • Download files written with EDM4hep versions for which we promise backwards compatibility and check whether we can still read them correctly.

ENDRELEASENOTES

@tmadlener
Copy link
Contributor Author

I have created the necessary directory on eos to upload files and added the CMake infrastructure to fetch them via the ExternalData functionality on the fly here as well. For testing / developing purposes, I have uploaded files that are created with the latest tag of podio and EDM4hep from this PR, we will need to tag EDM4hep again and replace those files to have a really well defined version for those files to make them reproducible. The schema of EDM4hep hasn't changed since v00-99, but the content you get from createEDM4hepFile.py has.

Maybe this PR needs to be split into two parts, to make it possible to create a tag in between, so that the parts with the backwards compatibility can work off of well defined versions.

@tmadlener
Copy link
Contributor Author

I will upload new files once we have tags for EDM4hep and podio, then the checks should pass. I don't foresee any more code changes now, unless there are comments from reviewing it.

@tmadlener
Copy link
Contributor Author

I have added newly produced files (from podio and EDM4hep master / main branches), to verify that things work if both are at their current head. After both have been tagged, I will upload files produced with the actually tagged version and update this accordingly.

@tmadlener tmadlener changed the title [WIP] Add read tests to ensure backwards compatibility Add read tests to ensure backwards compatibility Sep 20, 2024
@tmadlener
Copy link
Contributor Author

Input files from tagged podio and EDM4hep have been uploaded and are now used for the tests. The old files from intermediate testing have been removed again.

@tmadlener
Copy link
Contributor Author

Following this comment, I have added -p no:gaudi_fixtures to the pytest.ini. That stops the pollution of the output with the complete python file that was used for testing. That also makes it possible to keep the normal FAIL_REGULAR_EXPRESSION.

Unless someone wants to still have a look and comment, I would merge this either later today or early tomorrow.

@hegner
Copy link
Contributor

hegner commented Sep 25, 2024

@tmadlener - what's the issue with the failing test on the downstream-build ?

@tmadlener
Copy link
Contributor Author

That seems to be an unrelated test failure in k4SimDelphes. Looks like it has been failing there as well. I will have a look.

@tmadlener tmadlener merged commit c427374 into key4hep:main Sep 26, 2024
7 of 10 checks passed
@tmadlener tmadlener deleted the backwards-compat-tests branch September 26, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants