-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IOSvc: Minor fixes for improving usage and errors #213
Conversation
348fe67
to
b9113e2
Compare
This should be ready to be merged. I will merge today if there aren't any comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be changed to .Input
and .Output
too, no?
k4FWCore/test/k4FWCoreTest/options/runFunctionalMix.py
Lines 69 to 71 in 005dd3e
iosvc = IOSvc("IOSvc") | |
iosvc.input = "functional_producer_multiple.root" | |
iosvc.output = "functional_mix_iosvc.root" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If think it might be simpler if we say to just always import ApplicationMgr
from k4FWCore
rather than if there is IOSvc then import from k4FWCore
otherwise import from k4FWCore
or Configurables
.
In a similar vain maybe all the examples could import from k4FWCore
rather than importing from Configurables
when possible?
Maybe in a longer run we could port our custom python wrappers (ApplicationMgr.py
, IOSvc.py
) back to C++ (no extra checks or python parsing needed on our side, users can import all they need from Configurables
, easier to extend by users if needed)
005dd3e
to
c1da2ad
Compare
I agree this is a good idea and now all the examples import from k4FWCore.
About this I'm not sure, for |
6afb58f
to
df2aace
Compare
…bles since a few features depend on it and when it fails it's not clear that importing from Configurables is the reason.
BEGINRELEASENOTES
IOSvc
orApplicationMgr
are not imported withfrom k4FWCore import IOSvc
(it can be imported fromConfigurables
). The python wrapper in k4FWCore does a few minor things and importing fromConfigurables
doesn't fail currently and can lead to hard to solve issues.events
category. Currently it fails with an error in python that is not very clear.Input
andOutput
for IOSvc, deprecateinput
andoutput
since all the other properties are capitalized. The same forIOType
instead ofioType
. This will print a warning about a duplicated property that should be ignored for now.EventLoopMgr
.ApplicationMgr
always fromk4FWCore
ENDRELEASENOTES
The two warnings are these:
they will appear always and this feature is not being used. In any case, this only overrides the default case, someone can create an
EventLoopMgr
and have the warnings. I opened an issue in Gaudi.The most important is failing when importing
ApplicationMgr
fromConfigurables
as most of the examples do not set the algorithms for reading and writing that the user doesn't need to worry about in almost any case, but the wrapper ink4FWCore
does so one only needs to specifyIOSvc.Input
orIOSvc.Output
.