Fix warnings when warnings are enabled #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-fila
reviewed
Aug 13, 2024
test/k4FWCoreTest/src/components/k4FWCoreTest_cellID_reader.cpp
Outdated
Show resolved
Hide resolved
test/k4FWCoreTest/src/components/ExampleFunctionalConsumerRuntimeCollectionsMultiple.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Mateusz Jakub Fila <37295697+m-fila@users.noreply.github.com>
|
Looks like the |
|
Should be fixed now, I must have rebased without pulling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was compiling k4Reco and getting warnings about files in k4FWCore and it turns out that warnings are not enabled in k4FWCore but are in k4Reco. I propose a general solution for all the Key4hep repositories in key4hep/key4hep-dev-utils#5 so feel free to have a look and comment.
BEGINRELEASENOTES
ENDRELEASENOTES