-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use podio::Reader and podio::Writer with IOSvc #233
base: main
Are you sure you want to change the base?
Conversation
7b1ced1
to
90cbc27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to dynamically allocate the writer and reader?
- They already are type erased
getWriter()
always return a valid object and is always assumed to do so- I think the wrtier's
finish
method could be called directly instead triggering with pointer reset, no?
if (m_outputType != "default" && m_outputType != "ROOT" && m_outputType != "RNTuple") { | ||
error() << "Unknown input type: " << m_outputType << ", expected ROOT, RNTuple or default" << endmsg; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
podio::Writer
allows also SIO. Is this intentional to exclude it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The demand for writing EDM4hep files using SIO is quite low. If someone wants it we can add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be nice for some testing at some point, but I agree we can easily toggle this once it becomes necessary.
90cbc27
to
21095c2
Compare
BEGINRELEASENOTES
IOType
parameter given toIOSvc
in the steering file.ENDRELEASENOTES