Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add event header to conversion #106

Merged
merged 33 commits into from
Apr 19, 2023
Merged

Add event header to conversion #106

merged 33 commits into from
Apr 19, 2023

Conversation

bistapf
Copy link
Contributor

@bistapf bistapf commented Apr 17, 2023

BEGINRELEASENOTES

  • Add the event header to conversion from Delphes to edm4hep output. The event weight (as returned by generator) as well as the event number will be filled as members.
    ENDRELEASENOTES

Birgit Stapf and others added 27 commits January 24, 2023 14:19
adding unit tests for pythia converter with the FCC-hh cards
521bfcc
adding readme for nan issue in delphes vs edm4hep comparison tests wi…
3119e42 
…th FCC-hh cards
add script checking existing files for nans
9f72235
adding helper files to run tests with FCC-hh cards
475c11f
adding test with different track collection
eca37d3
@bistapf
Merge branch 'key4hep:main' into main
c093755
@bistapf
Merge branch 'key4hep:main' into main
cbdbb56
add creating the event header to be able to fill generator weight - l…
601a119 
…oading weight from delphes not yet functional
fill EventHeader.Weight with the Weight from Delphes
75ef3e4
rewriting loading the event weight from delphes - needed to add this …
eedc734 
…branch to pythia reader
clean up event header code
c708d9c
@bistapf
Merge branch 'key4hep:main' into main
ed6db2d
Merge remote-tracking branch 'origin/main' into add_event_header
7b7baf7
fix trailing whitespace errors and remove unnecessary files
fe38ec6
fix clang-format
e798845
remove FCC-hh test delphes cards
a70635f
remove extra FCC-hh tester pythia card
73c48b9
clean up test debug printout
a69d4c1
@bistapf
Merge branch 'key4hep:main' into main
dbbd784
Merge remote-tracking branch 'origin/main' into add_event_header
025e418
remove obsolete files from tracking
715d953
fix trailing whitespaces
bf6b7b9
Merge branch 'main' of github.com:bistapf/k4SimDelphes into main
82b1b1e
fill also eventNumber from delphes
ebae0d0
clean up obsolote tests for fcc-hh delphes cards
b7e27fa
fix merge conflict
eaad94c
clean up tests
c36848c
@tmadlener
Copy link
Contributor

Thanks @bistapf,

My main question/comment at this point is whether we really need to make the name of the created EventHeaderCollection configurable. Given that there should always be exactly one per event, I would fix the name to "EventHeader" (consistent with what DD4hep does for EDM4hep) and put it as a constant into the header of the converter.

tmadlener
tmadlener reviewed Apr 17, 2023
View reviewed changes
converter/src/DelphesEDM4HepConverter.cc Outdated Show resolved Hide resolved
converter/src/DelphesEDM4HepConverter.cc Outdated Show resolved Hide resolved
standalone/src/DelphesPythia8Common.h Outdated Show resolved Hide resolved
converter/src/DelphesEDM4HepConverter.cc Outdated Show resolved Hide resolved
tmadlener
tmadlener approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this.

@tmadlener tmadlener enabled auto-merge (squash) April 19, 2023 11:04
@tmadlener tmadlener merged commit 5f136a3 into key4hep:main Apr 19, 2023
@bistapf bistapf mentioned this pull request Aug 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bistapf @tmadlener