Add Delphes isolation variable and ParticleFlowCandidates to edm4hep output #107
Conversation
…oading weight from delphes not yet functional
…branch to pythia reader
bistapf
changed the title
There was a problem hiding this comment.
Thanks for this as well :)
As a general comment could you remove the debug output that was introduced during development? There are also a few more comments / questions inline.
One "big picture" question: Currently the ParticleFlow candidates do not get a relation to an MC particle (like other ReconstructedParticles do). Since they are a somewhat Delphes internal thing, I am not sure if we should actually add one, or whether we leave them like it is.
Finally, could you also add documentation about these new features to doc/output_config.md.
converter/include/k4SimDelphes/DelphesEDM4HepOutputConfiguration.h
Outdated
Show resolved
Hide resolved
converter/include/k4SimDelphes/DelphesEDM4HepOutputConfiguration.h
Outdated
Show resolved
Hide resolved
converter/include/k4SimDelphes/DelphesEDM4HepOutputConfiguration.h
Outdated
Show resolved
Hide resolved
converter/include/k4SimDelphes/DelphesEDM4HepOutputConfiguration.h
Outdated
Show resolved
Hide resolved
|
Thanks for your feedback, Thomas :) I have implemented the suggested changes, updated the documentation and in particular added a statement there that currently the |
doc/output_config.md
Outdated
| @@ -41,6 +43,9 @@ the assumption that this is a non-overlapping list of particles. It is the users | |||
| responsibility to make sure that this is the case. (See [known | |||
| issues](#known-issues)). | |||
|
|
|||
| `ParticleFlowCandidate` collections from Delphes can also be stored as a `ReconstructedParticleCollection` in the output, but they currently have no associations to the generated particles. | |||
There was a problem hiding this comment.
They will also not be added to the global ReconstructedParticle collection as that would lead to double counting (given that the ParticleFlowCandidate is a somewhat Delphes internal class)
doc/output_config.md
Outdated
| | n/a | `MCRecoParticleAssociation` | | ||
|
|
||
| All Delphes classes that are not listed here are currently not converted. | ||
|
|
||
| ## EventHeader Collection | ||
| The `EventHeader` collection is used to store information from the Delphes `Event` classes. It contains one element for the `eventNumber` and one for the `weight`. This is currently only implemented for the `DelphesPythia8Reader`. |
There was a problem hiding this comment.
Technically, the eventNumber and weight are stored in a single edm4hep::EventHeader. The way it is currently written it could also be interpreted as if there are multiple of these with partial information each.
| * The settings steering the output of the DelphesEDM4HepConverter. Default | ||
| * values correspond to the ones found in delphes example cards. | ||
| */ | ||
| * The settings steering the output of the DelphesEDM4HepConverter. Default |
There was a problem hiding this comment.
Are these re-indentations really necessary? I suppose they are added automatically be by clang-format?
…eaer has one entry
…eaer has one entry
BEGINRELEASENOTES
ENDRELEASENOTES