Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

High-level comments on major files #1

Closed
maxtaco opened this issue Jan 11, 2015 · 0 comments
Closed

High-level comments on major files #1

maxtaco opened this issue Jan 11, 2015 · 0 comments
Milestone
Major feature parity

Comments

@maxtaco
Copy link
Contributor

maxtaco commented Jan 11, 2015

Issue by maxtaco
Wednesday Oct 08, 2014 at 19:46 GMT
Originally opened as https://github.com/keybase/go-libkb/issues/2

Comments needed on the major libraries, like globals.go and interfaces.go.
@maxtaco maxtaco added this to the Major feature parity milestone Jan 11, 2015
@maxtaco maxtaco closed this as completed Jan 11, 2015
maxtaco added a commit that referenced this issue Feb 24, 2015
@maxtaco
Close #1
e7783f6 
Try yet another strategy for packing arguments in Msgpack RPC.
All arguments are of the form [{params}], and therefore
are listed by name.  This is true for 0, 1, and 2+
length argument lists.  The same consistent format
is used in all.

The issue with the array-based approach is that it's pretty
fragile if arguments are added or deprecated.

cc: @gabriel
@malgorithms malgorithms mentioned this issue Sep 22, 2015
Closed
@fzg fzg mentioned this issue Mar 12, 2016
Open
@yield65 yield65 mentioned this issue Apr 6, 2016
Open
@jwildeboer jwildeboer mentioned this issue Aug 17, 2016
Closed
@lucasrca lucasrca mentioned this issue Sep 12, 2016
Closed
@PeterTGarner PeterTGarner mentioned this issue Oct 5, 2016
Open
@chrisnojima chrisnojima mentioned this issue Mar 30, 2017
Merged
@bleys bleys mentioned this issue Apr 8, 2017
Closed
@maxtaco maxtaco mentioned this issue May 13, 2017
Open
@artemist artemist mentioned this issue May 20, 2017
Open
maxtaco added a commit that referenced this issue Dec 21, 2017
@maxtaco
allow #1 implicit conflict generation
4b800ed 
- as per doc...
maxtaco added a commit that referenced this issue Dec 21, 2017
@maxtaco
allow #1 implicit conflict generation (#10004)
4091175 
- as per doc...
@rhorm rhorm mentioned this issue Jun 1, 2018
Closed
@akalin-keybase akalin-keybase mentioned this issue Aug 7, 2018
Closed
@ghost ghost mentioned this issue Aug 31, 2018
Open
maxtaco added a commit that referenced this issue Oct 11, 2018
@maxtaco
slacken FTL loading requirements
d01acd1 
- the way the auditor is written, we don't actually need intermediate subchains to start with unstubbed links
- we still need link #1 to be unstubbed
@maxtaco maxtaco mentioned this issue Oct 11, 2018
Merged
maxtaco added a commit that referenced this issue Oct 11, 2018
@maxtaco
slacken FTL loading requirements (#14208)
7768579 
- the way the auditor is written, we don't actually need intermediate subchains to start with unstubbed links
- we still need link #1 to be unstubbed
strib added a commit that referenced this issue Feb 14, 2019
@strib
chat: handle suffixes and readers when adding username to TLF
e9c235f 
Otherwise a valid TLF name like "a,b (conflicted copy 2019-02-14 #1)"
becomes "a,b (conflicted copy 2019-02-14 #1),a" and everything breaks.
@strib strib mentioned this issue Feb 14, 2019
Merged
strib added a commit that referenced this issue Feb 22, 2019
@strib
chat: handle suffixes and readers when adding username to TLF
db3fe30 
Otherwise a valid TLF name like "a,b (conflicted copy 2019-02-14 #1)"
becomes "a,b (conflicted copy 2019-02-14 #1),a" and everything breaks.
strib added a commit that referenced this issue Feb 25, 2019
@strib
chat: handle suffixes and readers when adding username to TLF
217c175 
Otherwise a valid TLF name like "a,b (conflicted copy 2019-02-14 #1)"
becomes "a,b (conflicted copy 2019-02-14 #1),a" and everything breaks.
@aaazalea aaazalea mentioned this issue Apr 26, 2019
Merged
@aaazalea aaazalea mentioned this issue Jun 7, 2019
Merged
@xmaysonnave xmaysonnave mentioned this issue Aug 13, 2019
Closed
@scaprile scaprile mentioned this issue Aug 15, 2019
Closed
@jryio jryio mentioned this issue Sep 4, 2019
Merged
@aaazalea aaazalea mentioned this issue Oct 18, 2019
Merged
@morgzz morgzz mentioned this issue Apr 23, 2020
Open
@yericua yericua mentioned this issue May 22, 2020
Open
@bljordan bljordan mentioned this issue May 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Major feature parity
Development

No branches or pull requests
1 participant
@maxtaco