Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RN 0.60.5 #18251

Merged
merged 47 commits into from
Sep 20, 2019
Merged

RN 0.60.5 #18251

merged 47 commits into from
Sep 20, 2019

Conversation

chrisnojima
Copy link
Contributor

@chrisnojima chrisnojima commented Jul 3, 2019 •
edited
Loading

  • desktop
  • desktop storybook
  • maybe update push
  • ios
  • android
  • tests (mostly work but emoji-mart update changed the api, will need to fix)
  • rn-storybook (kinda busted but it seems to mostly work. babel builds etc. just the web server doesn't seem to update the app) you have to refresh the web page and it works, kinda annoying but fine short term

notes:
Android

@chrisnojima chrisnojima changed the title Nojima/hotpot rn 60 WIP: RN 60.0 Jul 3, 2019
@chrisnojima chrisnojima changed the title WIP: RN 60.0 NoMerge: RN 60.0 freeze Jul 23, 2019
@chrisnojima
Copy link
Contributor Author

chrisnojima commented Sep 12, 2019 •
edited
Loading

  • recheck yarn diffs since freeze
  • height unset comments

@chrisnojima chrisnojima changed the title NoMerge: RN 60.0 freeze RN 0.60.5 Sep 13, 2019
chrisnojima
chrisnojima commented Sep 13, 2019
View reviewed changes
shared/android/app/src/main/AndroidManifest.xml Outdated
@@ -11,6 +11,11 @@
<uses-permission android:name="android.permission.READ_CONTACTS" />
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />

<meta-data android:name="com.dieam.reactnativepushnotification.notification_channel_name"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcoPolo maybe not needed after your changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcoPolo bump

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, kill this

@chrisnojima chrisnojima marked this pull request as ready for review September 13, 2019 20:12
@chrisnojima
Copy link
Contributor Author

chrisnojima commented Sep 13, 2019 •
edited
Loading

  • after release

@chrisnojima
Copy link
Contributor Author

chrisnojima commented Sep 13, 2019 •
edited
Loading

  • crashes on device

@chrisnojima chrisnojima requested a review from a team September 13, 2019 21:00
@chrisnojima
Copy link
Contributor Author

chrisnojima commented Sep 14, 2019 •
edited
Loading

  • text files failed

MarcoPolo
MarcoPolo approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also made sure this works on Android 👍

shared/common-adapters/markdown/generate-emoji-parser.tsx
import {escapeRegExp} from 'lodash-es'
// MUST be lodash for node to work simply
// eslint-disable-next-line
import {escapeRegExp} from 'lodash'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this file is only run once by our "preprocessor" flow.

@chrisnojima chrisnojima merged commit 5e30296 into master Sep 20, 2019
@chrisnojima chrisnojima deleted the nojima/HOTPOT-rn-60 branch September 20, 2019 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoPolo MarcoPolo MarcoPolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisnojima @MarcoPolo