Go test fails to compile #47

asiragusa · 2019-06-04T21:58:06Z

Go test fails to compile on my computer after installing the latest updates of Xcode command line tools, it worked fine until yesterday.

go test -v ./...  -tags skipsecretserviceintegrationtests
# github.com/keybase/go-keychain
./macos_1.10.go:89:13: could not determine kind of name for C.SecTrustedApplicationCreateFromPath
FAIL	github.com/keybase/go-keychain [build failed]
# github.com/keybase/go-keychain
./macos_1.10.go:89:13: could not determine kind of name for C.SecTrustedApplicationCreateFromPath
FAIL	github.com/keybase/go-keychain/bindtest [build failed]
=== RUN   TestNewKeypair
--- PASS: TestNewKeypair (0.00s)
=== RUN   TestKeygen
--- PASS: TestKeygen (0.00s)
=== RUN   TestEncryption
--- PASS: TestEncryption (0.00s)
=== RUN   TestEncryptionRng
--- PASS: TestEncryptionRng (0.00s)
=== RUN   TestPKCS7
--- PASS: TestPKCS7 (0.00s)
PASS
ok  	github.com/keybase/go-keychain/secretservice	0.015s

Xcode Version 10.2.1 (10E1001)

go version
go version go1.12.5 darwin/amd64

The text was updated successfully, but these errors were encountered:

zbuc · 2019-06-21T20:04:03Z

Seeing the same here.

go version go1.12.5 darwin/amd64

mtrung · 2019-07-29T22:56:59Z

Same here:

github.com/keybase/go-keychain
../../.go/pkg/mod/github.com/keybase/go-keychain@v0.0.0-20190604185112-cc436cc9fe98/macos_1.10.go:89:13: could not determine kind of name for C.SecTrustedApplicationCreateFromPath
make: *** [build] Error 2

go version go1.12.7 darwin/amd64

benbooth493 · 2019-07-31T06:22:07Z

Same here.

go version go1.12.7 darwin/amd64

nodefortytwo · 2019-09-02T11:52:24Z

Any chance of an update on this?

maxtaco · 2019-09-03T13:50:30Z

We'll check out a PR if anyone has a fix.

zbuc · 2019-09-03T18:14:55Z

Is anyone familiar with what the underlying API changes were?

…

On Tue, Sep 3, 2019 at 9:50 AM Maxwell Krohn ***@***.***> wrote: We'll check out a PR if anyone has a fix. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#47?email_source=notifications&email_token=AAELFOFJVFPLSLLHPR4KURDQHZTSPA5CNFSM4HTE2Z2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5YIF6I#issuecomment-527467257>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAELFOA3D5IXTHDC3HQBYGTQHZTSPANCNFSM4HTE2Z2A> .

groob · 2019-09-03T19:11:42Z

Is this still an issue in master? the macos_1.10.go etc files are removed.

zbuc · 2019-09-03T19:13:40Z

Is this still an issue in master? the macos_1.10.go etc files are removed.

Yep, they just renamed them:

 macos_1.10.go => macos.go                               |  13 ++--
 macos_1.10_test.go                                      |  65 ----------------
 macos_pre1.10.go                                        | 274 ----------------------------------------------------------------
 macos_pre1.10_test.go                                   |  47 -----------
 macos_test.go                                           |  56 ++++++++++++++

Still get the same error here on go version go1.12.9 darwin/amd64/XCode Command Line Tools 11.0.0.0.1.1559496560

groob · 2019-09-03T19:17:50Z

I cloned the project and ran the following, but I can't reproduce:

~/go/src/github.com/keybase/go-keychain >>> go test -count=1 -v ./...  -tags skipsecretserviceintegrationtests
=== RUN   TestUnixToAbsoluteTime
--- PASS: TestUnixToAbsoluteTime (0.00s)
=== RUN   TestAbsoluteTimeToUnix
--- PASS: TestAbsoluteTimeToUnix (0.00s)
=== RUN   TestTimeToCFDate
--- PASS: TestTimeToCFDate (0.00s)
=== RUN   TestCFDateToTime
--- PASS: TestCFDateToTime (0.00s)
=== RUN   TestAccess
--- PASS: TestAccess (0.04s)
=== RUN   TestAccessWithImpliedSelf
--- PASS: TestAccessWithImpliedSelf (0.01s)
=== RUN   TestAccessWithoutTrust
--- PASS: TestAccessWithoutTrust (0.01s)
=== RUN   TestUpdateItem
--- PASS: TestUpdateItem (0.02s)
=== RUN   TestAddingAndQueryingNewKeychain
--- PASS: TestAddingAndQueryingNewKeychain (0.02s)
=== RUN   TestNewWithPath
--- PASS: TestNewWithPath (0.02s)
=== RUN   TestStatus
--- PASS: TestStatus (0.01s)
=== RUN   TestGenericPasswordRef
--- PASS: TestGenericPasswordRef (0.01s)
=== RUN   TestInternetPassword
--- PASS: TestInternetPassword (0.00s)
PASS
ok  	github.com/keybase/go-keychain	0.165s
?   	github.com/keybase/go-keychain/bind	[no test files]
=== RUN   TestGenericPassword
--- PASS: TestGenericPassword (0.04s)
PASS
ok  	github.com/keybase/go-keychain/bindtest	0.088s
=== RUN   TestNewKeypair
--- PASS: TestNewKeypair (0.00s)
=== RUN   TestKeygen
--- PASS: TestKeygen (0.00s)
=== RUN   TestEncryption
--- PASS: TestEncryption (0.00s)
=== RUN   TestEncryptionRng
--- PASS: TestEncryptionRng (0.00s)
=== RUN   TestPKCS7
--- PASS: TestPKCS7 (0.00s)
PASS
ok  	github.com/keybase/go-keychain/secretservice	0.047s
~/go/src/github.com/keybase/go-keychain >>>

groob · 2019-09-03T19:18:50Z


package-id: com.apple.pkg.CLTools_Executables
version: 11.0.0.0.1.1559496560
volume: /
location: /
install-time: 1559666156
groups: com.apple.FindSystemFiles.pkg-group```

groob · 2019-09-03T19:25:17Z

@zbuc can you tell me a bit more about your setup:

pwd and go env output.

Newer versions of Go try to default to modules, but this project vendors dependencies and doesn't have go.mod support. I wonder if it's something related.

zbuc · 2019-09-03T19:31:03Z

`/Users/chris.czub/go/src/github.com/keybase/go-keychain` ```GOARCH="amd64" GOBIN="" GOCACHE="/Users/chris.czub/Library/Caches/go-build" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GOOS="darwin" GOPATH="/Users/chris.czub/go" GOPROXY="" GORACE="" GOROOT="/usr/local/Cellar/go/1.12.9/libexec" GOTMPDIR="" GOTOOLDIR="/usr/local/Cellar/go/1.12.9/libexec/pkg/tool/darwin_amd64" GCCGO="gccgo" CC="clang" CXX="clang++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/nq/xkgtdyrd5kn5sqhg7xysysww0000gn/T/go-build165751423=/tmp/go-build -gno-record-gcc-switches -fno-common"```

…

On Tue, Sep 3, 2019 at 3:25 PM Victor Vrantchan ***@***.***> wrote: @zbuc <https://github.com/zbuc> can you tell me a bit more about your setup: pwd and go env output. Newer versions of Go try to default to modules, but this project vendors dependencies and doesn't have go.mod support. I wonder if it's something related. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#47?email_source=notifications&email_token=AAELFOEI5BDTC3OJ3H6G2QTQH22Z7A5CNFSM4HTE2Z2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5ZJLSQ#issuecomment-527603146>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAELFOCXXIWRJB2HXICIOY3QH22Z7ANCNFSM4HTE2Z2A> .

alexanderbez · 2019-09-21T16:04:01Z

Getting this error on go 1.13:

/Users/aleksbez/go/pkg/mod/github.com/keybase/go-keychain@v0.0.0-20190712205309-48d3d31d256d/macos_1.10.go:89:13: could not determine kind of name for C.SecTrustedApplicationCreateFromPath

$ go get github.com/keybase/go-keychain@latest

go: finding github.com/keybase/go-keychain latest
go: downloading github.com/keybase/go-keychain v0.0.0-20190828153431-2390ae572545
go: extracting github.com/keybase/go-keychain v0.0.0-20190828153431-2390ae572545
# github.com/keybase/go-keychain
../../../../pkg/mod/github.com/keybase/go-keychain@v0.0.0-20190828153431-2390ae572545/macos.go:88:13: could not determine kind of name for C.SecTrustedApplicationCreateFromPath

Update: Updating my xcode dev tools fixed this.

$ sudo rm -rf /Library/Developer/CommandLineTools
$ xcode-select --install

alessio · 2019-09-21T16:29:46Z

It seems that SecTrustedApplication has been introduced in macOS SDK 10.2: https://developer.apple.com/documentation/security/sectrustedapplication

I'd advise to drop a note in the README.

joshblum · 2019-12-20T22:11:30Z

closed via #60

Just4Ease · 2020-12-08T13:30:55Z

Getting this error on go 1.13:

/Users/aleksbez/go/pkg/mod/github.com/keybase/go-keychain@v0.0.0-20190712205309-48d3d31d256d/macos_1.10.go:89:13: could not determine kind of name for C.SecTrustedApplicationCreateFromPath

$ go get github.com/keybase/go-keychain@latest

go: finding github.com/keybase/go-keychain latest
go: downloading github.com/keybase/go-keychain v0.0.0-20190828153431-2390ae572545
go: extracting github.com/keybase/go-keychain v0.0.0-20190828153431-2390ae572545
# github.com/keybase/go-keychain
../../../../pkg/mod/github.com/keybase/go-keychain@v0.0.0-20190828153431-2390ae572545/macos.go:88:13: could not determine kind of name for C.SecTrustedApplicationCreateFromPath

Update: Updating my xcode dev tools fixed this.

$ sudo rm -rf /Library/Developer/CommandLineTools
$ xcode-select --install

This didn't work for me, i use BigSur

alexanderbez mentioned this issue Sep 21, 2019

Add support for github.com/99designs/keyring-backed keybases cosmos/cosmos-sdk#5029

Merged

5 tasks

joshblum closed this as completed Dec 20, 2019

wolfstudy mentioned this issue Dec 8, 2020

Go build fails to compile apache/pulsar-client-go#407

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Go test fails to compile #47

Go test fails to compile #47

asiragusa commented Jun 4, 2019

zbuc commented Jun 21, 2019

mtrung commented Jul 29, 2019 •

edited

Loading

benbooth493 commented Jul 31, 2019 •

edited

Loading

nodefortytwo commented Sep 2, 2019

maxtaco commented Sep 3, 2019

zbuc commented Sep 3, 2019 via email

groob commented Sep 3, 2019

zbuc commented Sep 3, 2019

groob commented Sep 3, 2019

groob commented Sep 3, 2019

groob commented Sep 3, 2019

zbuc commented Sep 3, 2019 via email

alexanderbez commented Sep 21, 2019 •

edited

Loading

alessio commented Sep 21, 2019

joshblum commented Dec 20, 2019

Just4Ease commented Dec 8, 2020

Go test fails to compile #47

Go test fails to compile #47

Comments

asiragusa commented Jun 4, 2019

zbuc commented Jun 21, 2019

mtrung commented Jul 29, 2019 • edited Loading

benbooth493 commented Jul 31, 2019 • edited Loading

nodefortytwo commented Sep 2, 2019

maxtaco commented Sep 3, 2019

zbuc commented Sep 3, 2019 via email

groob commented Sep 3, 2019

zbuc commented Sep 3, 2019

groob commented Sep 3, 2019

groob commented Sep 3, 2019

groob commented Sep 3, 2019

zbuc commented Sep 3, 2019 via email

alexanderbez commented Sep 21, 2019 • edited Loading

alessio commented Sep 21, 2019

joshblum commented Dec 20, 2019

Just4Ease commented Dec 8, 2020

mtrung commented Jul 29, 2019 •

edited

Loading

benbooth493 commented Jul 31, 2019 •

edited

Loading

alexanderbez commented Sep 21, 2019 •

edited

Loading