Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always skip ci #95

Closed
wants to merge 1 commit into from
Closed

always skip ci #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion keybot/darwinbot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2015 Keybase, Inc. All rights reserved. Use of

Check failure on line 1 in keybot/darwinbot.go

View workflow job for this annotation

GitHub Actions / test (1.21.x, ubuntu-latest) 

: # github.com/keybase/slackbot/keybot [github.com/keybase/slackbot/keybot.test]
// this source code is governed by the included BSD license.

package main
Expand Down Expand Up @@ -30,7 +30,7 @@
buildDarwinClientCommit := buildDarwin.Flag("client-commit", "Build a specific client commit").String()
buildDarwinKbfsCommit := buildDarwin.Flag("kbfs-commit", "Build a specific kbfs commit").String()
buildDarwinNoPull := buildDarwin.Flag("skip-pull", "Don't pull before building the app").Bool()
buildDarwinSkipCI := buildDarwin.Flag("skip-ci", "Whether to skip CI").Bool()
buildDarwinSkipCI := true // buildDarwin.Flag("skip-ci", "Whether to skip CI").Bool()
buildDarwinSmoke := buildDarwin.Flag("smoke", "Whether to make a pair of builds for smoketesting when on a branch").Bool()
buildDarwinNoS3 := buildDarwin.Flag("skip-s3", "Don't push to S3 after building the app").Bool()
buildDarwinNoNotarize := buildDarwin.Flag("skip-notarize", "Don't notarize the app").Bool()
Expand Down Expand Up @@ -66,7 +66,7 @@

case buildDarwin.FullCommand():
smokeTest := true
skipCI := *buildDarwinSkipCI

Check failure on line 69 in keybot/darwinbot.go

View workflow job for this annotation

GitHub Actions / test (1.21.x, ubuntu-latest) 

invalid operation: cannot indirect buildDarwinSkipCI (variable of type bool)
testBuild := *buildDarwinTest
// If it's a custom build, make it a test build unless --smoke is passed.
if *buildDarwinClientCommit != "" || *buildDarwinKbfsCommit != "" {
Expand Down
6 changes: 3 additions & 3 deletions keybot/keybot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,17 @@
cancelLabel := cancel.Arg("label", "Launchd job label").String()

buildMobile := build.Command("mobile", "Start an iOS and Android build")
buildMobileSkipCI := buildMobile.Flag("skip-ci", "Whether to skip CI").Bool()
buildMobileSkipCI := true // buildMobile.Flag("skip-ci", "Whether to skip CI").Bool()
buildMobileAutomated := buildMobile.Flag("automated", "Whether this is a timed build").Bool()
buildMobileCientCommit := buildMobile.Flag("client-commit", "Build a specific client commit hash").String()

buildAndroid := build.Command("android", "Start an android build")
buildAndroidSkipCI := buildAndroid.Flag("skip-ci", "Whether to skip CI").Bool()
buildAndroidSkipCI := true // buildAndroid.Flag("skip-ci", "Whether to skip CI").Bool()
buildAndroidAutomated := buildAndroid.Flag("automated", "Whether this is a timed build").Bool()
buildAndroidCientCommit := buildAndroid.Flag("client-commit", "Build a specific client commit hash").String()
buildIOS := build.Command("ios", "Start an ios build")
buildIOSClean := buildIOS.Flag("clean", "Whether to clean first").Bool()
buildIOSSkipCI := buildIOS.Flag("skip-ci", "Whether to skip CI").Bool()
buildIOSSkipCI := true // buildIOS.Flag("skip-ci", "Whether to skip CI").Bool()
buildIOSAutomated := buildIOS.Flag("automated", "Whether this is a timed build").Bool()
buildIOSCientCommit := buildIOS.Flag("client-commit", "Build a specific client commit hash").String()

Expand Down Expand Up @@ -92,7 +92,7 @@
return launchd.Stop(*cancelLabel)

case buildMobile.FullCommand():
skipCI := *buildMobileSkipCI

Check failure on line 95 in keybot/keybot.go

View workflow job for this annotation

GitHub Actions / test (1.21.x, ubuntu-latest) 

invalid operation: cannot indirect buildMobileSkipCI (variable of type bool)
automated := *buildMobileAutomated
script := launchd.Script{
Label: "keybase.build.mobile",
Expand All @@ -114,7 +114,7 @@
return runScript(bot, channel, env, script)

case buildAndroid.FullCommand():
skipCI := *buildAndroidSkipCI

Check failure on line 117 in keybot/keybot.go

View workflow job for this annotation

GitHub Actions / test (1.21.x, ubuntu-latest) 

invalid operation: cannot indirect buildAndroidSkipCI (variable of type bool)
automated := *buildAndroidAutomated
script := launchd.Script{
Label: "keybase.build.android",
Expand All @@ -133,7 +133,7 @@
return runScript(bot, channel, env, script)

case buildIOS.FullCommand():
skipCI := *buildIOSSkipCI

Check failure on line 136 in keybot/keybot.go

View workflow job for this annotation

GitHub Actions / test (1.21.x, ubuntu-latest) 

invalid operation: cannot indirect buildIOSSkipCI (variable of type bool)
iosClean := *buildIOSClean
automated := *buildIOSAutomated
script := launchd.Script{
Expand Down
2 changes: 1 addition & 1 deletion keybot/winbot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
buildWindowsCientCommit := buildWindows.Flag("client-commit", "Build a specific client commit").String()
buildWindowsKbfsCommit := buildWindows.Flag("kbfs-commit", "Build a specific kbfs commit").String()
buildWindowsUpdaterCommit := buildWindows.Flag("updater-commit", "Build a specific updater commit").String()
buildWindowsSkipCI := buildWindows.Flag("skip-ci", "Whether to skip CI").Bool()
buildWindowsSkipCI := true // buildWindows.Flag("skip-ci", "Whether to skip CI").Bool()
buildWindowsSmoke := buildWindows.Flag("smoke", "Build a smoke pair").Bool()
buildWindowsDevCert := buildWindows.Flag("dev-cert", "Build using devel code signing cert").Bool()
buildWindowsAuto := buildWindows.Flag("automated", "Specify build was triggered automatically").Hidden().Bool()
Expand Down Expand Up @@ -104,7 +104,7 @@

case buildWindows.FullCommand():
smokeTest := *buildWindowsSmoke
skipCI := *buildWindowsSkipCI

Check failure on line 107 in keybot/winbot.go

View workflow job for this annotation

GitHub Actions / test (1.21.x, ubuntu-latest) 

invalid operation: cannot indirect buildWindowsSkipCI (variable of type bool) (typecheck)
skipTestChannel := *buildWindowsTest
devCert := 0
if *buildWindowsDevCert {
Expand Down
Loading