-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEYCLOAK-5771 #97
KEYCLOAK-5771 #97
Conversation
…k.protect` in order to facilitate async operations in the middleware.
3 similar comments
…olean value of the return in resolve
Thanks for the contribution. There are some tests failing here so seems like there's some regressions introduced. We are currently in feature freeze for Keycloak 3.x and won't be able to merge this until we start development on Keycloak 4.x. |
I'll get it fixed up this weekend. Thanks! |
2 similar comments
@beau6183 please rebase your changes against master and squash your commits into a single commit. |
@beau6183 please rebase and squash |
@beau6183 closing it. Please reopen the PR if you still want to work on it. |
Introduces the option to return a promise from
keycloak.protect
in order to facilitate async operations in the middleware.