Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEYCLOAK-5771 #97

Closed
wants to merge 8 commits into from
Closed

KEYCLOAK-5771 #97

wants to merge 8 commits into from

Conversation

beau6183
Copy link

Introduces the option to return a promise from keycloak.protect in order to facilitate async operations in the middleware.

@coveralls
Copy link

coveralls commented Oct 31, 2017

Coverage Status

Coverage increased (+0.2%) to 76.227% when pulling 383627b on athlinks:KEYCLOAK-5771 into 2c9a69f on keycloak:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 75.641% when pulling 16f5510 on athlinks:KEYCLOAK-5771 into 2c9a69f on keycloak:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 75.641% when pulling 16f5510 on athlinks:KEYCLOAK-5771 into 2c9a69f on keycloak:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 75.641% when pulling 16f5510 on athlinks:KEYCLOAK-5771 into 2c9a69f on keycloak:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 75.641% when pulling 16f5510 on athlinks:KEYCLOAK-5771 into 2c9a69f on keycloak:master.

@coveralls
Copy link

coveralls commented Oct 31, 2017

Coverage Status

Coverage decreased (-0.3%) to 75.641% when pulling ca17526 on athlinks:KEYCLOAK-5771 into 2c9a69f on keycloak:master.

@coveralls
Copy link

coveralls commented Nov 13, 2017

Coverage Status

Coverage decreased (-0.3%) to 85.592% when pulling 1fe692d on athlinks:KEYCLOAK-5771 into 19f64aa on keycloak:master.

@stianst
Copy link
Contributor

stianst commented Nov 27, 2017

Thanks for the contribution. There are some tests failing here so seems like there's some regressions introduced.

We are currently in feature freeze for Keycloak 3.x and won't be able to merge this until we start development on Keycloak 4.x.

@beau6183
Copy link
Author

beau6183 commented Dec 1, 2017

I'll get it fixed up this weekend. Thanks!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 85.459% when pulling e9a12ec on athlinks:KEYCLOAK-5771 into 4b3b6b1 on keycloak:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 85.459% when pulling e9a12ec on athlinks:KEYCLOAK-5771 into 4b3b6b1 on keycloak:master.

@coveralls
Copy link

coveralls commented Jan 16, 2018

Coverage Status

Coverage decreased (-0.3%) to 85.459% when pulling e9a12ec on athlinks:KEYCLOAK-5771 into 4b3b6b1 on keycloak:master.

@abstractj
Copy link

@beau6183 please rebase your changes against master and squash your commits into a single commit.

@stianst
Copy link
Contributor

stianst commented Jan 31, 2018

@beau6183 please rebase and squash

@abstractj
Copy link

@beau6183 closing it. Please reopen the PR if you still want to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants