Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating set-version.sh and adding set-server-version.sh. Updated server version to 26.0.7 #640

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

mposolda
Copy link
Contributor

@mposolda mposolda commented Dec 4, 2024

closes #639

  • Updated set-version.sh script to update only project version, but not version of keycloak server

  • Introduced set-server-version.sh script, which is used to update all the references to keycloak server, but does not update project version. I am planning to run this script from keycloak-rel during keycloak server release as during server release, we are not updating anymore the project version, but we need to update "keycloak server version" .

  • Small adjustements needed in the sed commands as the string $$VERSION$$ may not be available anymore in the kubernetes.yml and openshift.yml files. It would be needed to be able to replace also something like version: 26.0.7 with something like version: 26.0.8, which was not supported by previous sed scripts, which assume string $$VERSION$$

  • Updated server version to last released 26.0.7 used separate commit for that to not mix with updated bash scripts. (Hopefully in the future, this will be always done automatically in the quickstarts main branch for further keycloak server releases.)

closes keycloak#639

Signed-off-by: mposolda <mposolda@gmail.com>
Signed-off-by: mposolda <mposolda@gmail.com>
@mposolda mposolda changed the title 639 set server version Updating set-version.sh and adding set-server-version.sh. Updated server version to 26.0.7 Dec 4, 2024
@mposolda mposolda self-assigned this Dec 4, 2024
Copy link
Contributor

@graziang graziang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mposolda Thanks, LGTM!

@mposolda
Copy link
Contributor Author

mposolda commented Dec 5, 2024

@graziang Thanks!

@mposolda mposolda merged commit 1e1fcb1 into keycloak:main Dec 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust set-version.sh script in keycloak-quickstarts
2 participants