Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken Migration "MigrateTo24_0_0" #27779

Closed
1 of 2 tasks
PetkoNosal opened this issue Mar 11, 2024 · 1 comment · Fixed by #27861
Closed
1 of 2 tasks

Broken Migration "MigrateTo24_0_0" #27779

PetkoNosal opened this issue Mar 11, 2024 · 1 comment · Fixed by #27861
Assignees
@ahus1 @PetkoNosal
Labels
area/core kind/bug Categorizes a PR related to a bug kind/regression priority/blocker Highest Priority. Has a deadline and it blocks other tasks release/24.0.2 release/25.0.0 team/core-shared
Milestone
25.0.0

Comments

@PetkoNosal
Copy link
Contributor

Before reporting an issue

  • I have read and understood the above terms for submitting issues, and I understand that my issue may be closed without action if I do not follow them.

Area

core

Describe the bug

Class MigrateTo24_0_0 have broken bindFirstBrokerLoginFlow method. If you have realm that is using "First broker login" method is trying to set it and then log it with

LOG.debugf("Flow '%s' has been bound to realm %s as 'First broker login' flow", realm.getName());

As you can see, only one argument is provided and so log will fail with exception, which will then roll back transaction and basically shuts down whole server

Version

24.0.x

Regression

  • The issue is a regression

Expected behavior

Migration "MigrateTo24_0_0" does not kill whole server

Actual behavior

Migration "MigrateTo24_0_0" will kill the whole server

How to Reproduce?

Have a keycloak realm that have First broker login flow set up and then migrate to 24.0.x

Anything else?

No response
@PetkoNosal PetkoNosal added kind/bug Categorizes a PR related to a bug status/triage labels Mar 11, 2024
@PetkoNosal
Copy link
Contributor Author

I have created PR but dunno how to link it to the issue:

#27784

PetkoNosal pushed a commit to PetkoNosal/keycloak that referenced this issue Mar 13, 2024
keycloak#27779 Fix missing log argument in MigrateTo24_0_0
f77b138 
Signed-off-by: Nosal, Peter (pn1895) <pn1895@att.com>
@PetkoNosal PetkoNosal mentioned this issue Mar 13, 2024
Merged
@keycloak-github-bot keycloak-github-bot bot added kind/regression priority/blocker Highest Priority. Has a deadline and it blocks other tasks and removed status/triage action/priority-regression labels Mar 13, 2024
@keycloak-github-bot keycloak-github-bot bot added this to the 25.0.0 milestone Mar 13, 2024
ahus1 pushed a commit that referenced this issue Mar 13, 2024
@PetkoNosal
Fix missing log argument in MigrateTo24_0_0
3989cb5 
Closes #27779

Signed-off-by: Nosal, Peter (pn1895) <pn1895@att.com>
Co-authored-by: Nosal, Peter (pn1895) <pn1895@att.com>
ahus1 pushed a commit to ahus1/keycloak that referenced this issue Mar 15, 2024
@PetkoNosal @ahus1
Fix missing log argument in MigrateTo24_0_0
128edb1 
Closes keycloak#27779

Signed-off-by: Nosal, Peter (pn1895) <pn1895@att.com>
Co-authored-by: Nosal, Peter (pn1895) <pn1895@att.com>
@ahus1 ahus1 mentioned this issue Mar 15, 2024
Merged
mhajas pushed a commit that referenced this issue Mar 15, 2024
@ahus1 @PetkoNosal
Fix missing log argument in MigrateTo24_0_0 (#27922)
f8bbe84 
Closes #27779

Signed-off-by: Nosal, Peter (pn1895) <pn1895@att.com>
Co-authored-by: PetkoNosal <PetkoNosal@users.noreply.github.com>
Co-authored-by: Nosal, Peter (pn1895) <pn1895@att.com>
@santiagolizardo santiagolizardo mentioned this issue Jun 5, 2024
Closed
@shini4i shini4i mentioned this issue Jun 12, 2024
Merged
@jookzie jookzie mentioned this issue Jun 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahus1 ahus1

@PetkoNosal PetkoNosal

Labels
area/core kind/bug Categorizes a PR related to a bug kind/regression priority/blocker Highest Priority. Has a deadline and it blocks other tasks release/24.0.2 release/25.0.0 team/core-shared
Projects
None yet
Milestone
25.0.0
Development

Successfully merging a pull request may close this issue.

Fix missing log argument in MigrateTo24_0_0 PetkoNosal/keycloak
2 participants
@ahus1 @PetkoNosal