Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit SessionsResource#realmSessions as it current loads all sessions into memory #29203

Closed
ahus1 opened this issue May 2, 2024 · 1 comment · Fixed by #29204
Closed

Revisit SessionsResource#realmSessions as it current loads all sessions into memory #29203

ahus1 opened this issue May 2, 2024 · 1 comment · Fixed by #29204
Assignees
@ahus1
Labels
kind/enhancement Categorizes a PR related to an enhancement release/25.0.0

Comments

@ahus1
Copy link
Contributor

ahus1 commented May 2, 2024 •
edited
Loading

On a realm level, an admin can search the sessions with a string restricting it by user, client ID and IP address.

Some of the logic should change as it should take the session ID and the offline/online flag to determine unique entries. In addition to that, for a lot of persistent sessions in the database, the searching should leverage more of the database capabilities and load fewer items to memory.
@ahus1 ahus1 mentioned this issue May 2, 2024
Closed
@ahus1 ahus1 self-assigned this May 2, 2024
@ahus1 ahus1 added the kind/enhancement Categorizes a PR related to an enhancement label May 2, 2024
@ahus1 ahus1 mentioned this issue May 2, 2024
Merged
@ahus1
Copy link
Contributor Author

ahus1 commented May 2, 2024

This issue has been trimmed down to fix only the result returned here. Optimizations for the search in the backend are left for a future point in time.

ahus1 added a commit to ahus1/keycloak that referenced this issue May 3, 2024
@ahus1
Rework the result for the session search to contain a single result p…
8049bd5 
…er user sessions

Closes keycloak#29203

Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
ahus1 added a commit that referenced this issue May 3, 2024
@ahus1
Rework the result for the session search to contain a single result p…
df47dee 
…er user sessions

Closes #29203

Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
@sschu sschu mentioned this issue May 6, 2024
Closed
2 tasks
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahus1 ahus1

Labels
kind/enhancement Categorizes a PR related to an enhancement release/25.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework the result for the session search to contain a single result per user sessions ahus1/keycloak
1 participant
@ahus1