Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call JPA code in blocking thread #32154

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Call JPA code in blocking thread #32154

merged 1 commit into from
Aug 16, 2024
+4 −9

Conversation

ahus1
Copy link
Contributor

@ahus1 ahus1 commented Aug 15, 2024

Closes #32153

@ahus1 ahus1 self-assigned this Aug 15, 2024
@ahus1
Copy link
Contributor Author

ahus1 commented Aug 15, 2024

@pruivo - I'm a bit unsure if this is the elegant way to fix this, and if other places might be affected. Not urgent though - please have a look when you have the time.

pruivo
pruivo suggested changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@pruivo pruivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ahus1. The use of limit seems wrong to me and I suggested a couple of changes.
Here is the only place where it is used.

.../src/main/java/org/keycloak/models/sessions/infinispan/remote/RemoteUserSessionProvider.java Outdated Show resolved Hide resolved
.../src/main/java/org/keycloak/models/sessions/infinispan/remote/RemoteUserSessionProvider.java Outdated Show resolved Hide resolved
.../src/main/java/org/keycloak/models/sessions/infinispan/remote/RemoteUserSessionProvider.java Outdated Show resolved Hide resolved
@ahus1
Call JPA code in blocking thread
113ffca 
Closes keycloak#32153

Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
@ahus1 ahus1 force-pushed the is-32153-fix-jpa-call-in-async-thread branch from 8a32b29 to 113ffca Compare August 15, 2024 15:21
@ahus1 ahus1 marked this pull request as ready for review August 15, 2024 19:02
@ahus1 ahus1 requested a review from a team as a code owner August 15, 2024 19:02
mhajas
mhajas approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@mhajas mhajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on the review from @pruivo

@mhajas mhajas merged commit 88904c0 into keycloak:main Aug 16, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pruivo pruivo pruivo approved these changes

@mhajas mhajas mhajas approved these changes

Assignees

@ahus1 ahus1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remote Infinispan code must not call JPA code in non-blocking thread
3 participants
@ahus1 @pruivo @mhajas