Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping tests to 8.0.0 #177

Closed
wants to merge 1 commit into from
Closed

Bumping tests to 8.0.0 #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
test:
docker:
- image: circleci/golang:1.11.4
- image: jboss/keycloak:7.0.0
- image: jboss/keycloak:8.0.0
environment:
DB_VENDOR: H2
KEYCLOAK_LOGLEVEL: DEBUG
Expand Down
10 changes: 5 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ GO111MODULE=on go mod download && make build

## Supported Versions

Currently, this provider is tested against Terraform v0.12.1 and Keycloak v7.0.0. I personally use this provider with Terraform v0.11.x and Keycloak 4.8.3.Final.
Currently, this provider is tested against Terraform v0.12.1 and Keycloak v8.0.0. I personally use this provider with Terraform v0.11.x and Keycloak 4.8.3.Final.

In the future, it would be nice to [run acceptance tests using different versions of Terraform / Keycloak](https://github.com/mrparkers/terraform-provider-keycloak/issues/111). Please feel free to submit a PR if you believe you can help with this.

Expand All @@ -30,10 +30,10 @@ For local development, you can spin up a local instance of Keycloak, backed by P
Once the environment is ready, you can run the acceptance tests after setting the required environment variables:

```
KEYCLOAK_CLIENT_ID=terraform \
KEYCLOAK_CLIENT_SECRET=884e0f95-0f42-4a63-9b1f-94274655669e \
KEYCLOAK_REALM=master \
KEYCLOAK_URL="http://localhost:8080" \
export KEYCLOAK_CLIENT_ID=terraform \
export KEYCLOAK_CLIENT_SECRET=884e0f95-0f42-4a63-9b1f-94274655669e \
export KEYCLOAK_REALM=master \
export KEYCLOAK_URL="http://localhost:8080" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as-is without the export statements. Is there a reason this needed to be changed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexashley made me do it.

make testacc
```

Expand Down
6 changes: 3 additions & 3 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ services:
ports:
- 8389:389
keycloak:
image: jboss/keycloak:7.0.0
image: jboss/keycloak:8.0.0
depends_on:
- postgres
- openldap
Expand All @@ -29,8 +29,8 @@ services:
- DB_PASSWORD=password
- KEYCLOAK_USER=keycloak
- KEYCLOAK_PASSWORD=password
- POSTGRES_PORT_5432_TCP_ADDR=postgres
- POSTGRES_PORT_5432_TCP_PORT=5432
- DB_ADDR=postgres
- DB_PORT=5432
ports:
- 8080:8080
volumes:
Expand Down