Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for tests that are failing on keycloak version >= 9 #300

Merged

Conversation

tomrutsaert
Copy link
Contributor

@tomrutsaert tomrutsaert commented May 26, 2020

  • fix issue 291: creating resource keycloak_user with federated_identity fails with keycloak >= 9 #291
  • Disable customIdp test and example:
    The custom idp example and test do not work in keycloak 10, because the interfaces that our customIdp implements, have changed in the keycloak latest version.
    We need to make decide which keycloak version we going to support and test for the customIdp
  • Fix for google-custom-idp not existing. this scenario was already covered by the above point so unneeded, the custom config is still checked

@hawknewton
Copy link
Contributor

Ideally we'd support both and detect the server version at runtime.

@tomrutsaert
Copy link
Contributor Author

If you are talking about customidp, yes i agree.
This is about starting the discussion en in mean time helping 10.0.1 version pass in #294.

If you are talking about #291 fix, this fix does support both and does not need runtime version check.

@tomrutsaert tomrutsaert changed the title Keycloak9plus fed identity fix Fixes for tests that are failing on keycloak version >= 9 May 27, 2020
@tomrutsaert tomrutsaert merged commit 84bdfe8 into keycloak:master May 27, 2020
@tomrutsaert tomrutsaert deleted the keycloak9plus_fed_identity_fix branch May 27, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants