fix: client default/optional scopes first apply problem #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vlad Kirichenko <v.kirichenko@napoleongames.be>
…keycloak into fix-openid-client-scopes
…& added error log for not found client Signed-off-by: Vlad Kirichenko <v.kirichenko@napoleongames.be>
…keycloak into fix-openid-client-scopes
mrparkers
reviewed
Sep 14, 2021
| @@ -232,7 +232,9 @@ func (keycloakClient *KeycloakClient) getOpenidClientScopes(realmId, clientId, t | |||
| var scopes []*OpenidClientScope | |||
|
|
|||
| err := keycloakClient.get(fmt.Sprintf("/realms/%s/clients/%s/%s-client-scopes", realmId, clientId, t), &scopes, nil) | |||
| if err != nil { | |||
| if err != nil && ErrorIs404(err) { | |||
| return nil, fmt.Errorf("validation error: client with id %s does not exist", clientId) | |||
There was a problem hiding this comment.
was there a particular reason that this is needed? normally, we check for 404 errors within the provider package.
There was a problem hiding this comment.
Good point. I saw a problem in the TestAccKeycloakOpenidClientDefaultScopes_validateClientDoesNotExist test, and saw that the validation is missing when getting for scopes. Therefore, I added it.
It's strange that this check didn't work here.
…keycloak into fix-openid-client-scopes
mrparkers
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @mrparkers.
Changes in this PR gonna fix problem mentioned in #498.
Best regards,
Vlad