Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): serialize tests for core/wasm on mac agents #11795

Merged
merged 1 commit into from
Jun 17, 2024
Merged

fix(core): serialize tests for core/wasm on mac agents #11795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion core/commands.inc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,14 @@ do_test() {
if [[ $target =~ ^(x86|x64)$ ]]; then
cmd //C build.bat $target $BUILDER_CONFIGURATION test $testparams
else
meson test -C "$MESON_PATH" $testparams
if [[ $target == wasm ]] && [[ $BUILDER_OS == mac ]]; then
# 11794 -- parallel tests failing on some mac build agents; temporary
# mitigation until we diagnose root cause
meson test -j 1 -C "$MESON_PATH" $testparams
else
meson test -C "$MESON_PATH" $testparams
fi

fi
builder_finish_action success test:$target
}
Expand Down
4 changes: 2 additions & 2 deletions docs/build/macos.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,10 @@ PATH="$HOMEBREW_PREFIX/opt/coreutils/libexec/gnubin:$PATH"

## KeymanWeb Dependencies

* node.js 18+, emscripten 3.1.46 or later, openjdk 8
* node.js 22+, emscripten 3.1.46 or later

```shell
brew install node emscripten openjdk@8
brew install node emscripten
```

Note: if you install emscripten with brew on macOS, only emscripten binaries are
Expand Down
Loading