Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(android): Disable auto-correct UI controls #12791

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

darcywong00
Copy link
Contributor

@darcywong00 darcywong00 commented Dec 6, 2024

Addresses the Android portion of #12767

For Keyman 18.0, we'll disable auto-correct to mature the feature.

This disables the "Predictions with auto-corrections" UI that was added in #12443

Screenshot

Updated radio buttons (removed "Predictions with auto-corrections")

disable-suggestions

User Testing

Setup - Install the PR build of Keyman for Android on an Android device/emulator

  • TEST_AUTO_CORRECT_DISABLED - Verifies UI for "predictions with auto-corrections" disabled
  1. Launch Keyman for Android and dismiss the "Get Started" keyboard
  2. With the default sil_euro_latin keyboard, verify the keyboard displays suggestions by default
  3. Go to Keyman Settings --> Installed Languages --> English -->
  4. On the "English Settings" menu, verify the radio button "Predictions with corrections" is enabled by default
  5. Verify "Predictions with auto-corrections" does not appear
  6. Set the radio button to "Disable suggestions" and exit the settings menus
  7. Back in the Keyman app, verify the OSK refreshes with the Keyman image banner
  8. Verify suggestions no longer appear

@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Dec 6, 2024
@darcywong00 darcywong00 added this to the A18S16 milestone Dec 6, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Dec 6, 2024

@sgschantz sgschantz self-assigned this Dec 6, 2024
Copy link
Contributor

@sgschantz sgschantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dinakaranr
Copy link

dinakaranr commented Dec 6, 2024

Test Results

I tested this issue with the attached "Keyman 18.0.154-alpha-test-12791" build (taken from Team City) on the Android 14 physical device & Android 12 emulator device.

  • TEST_AUTO_CORRECT_DISABLED (Passed): 
  1. Installed the "Keyman-18.0.154.apk" file. Open the Keyman app.
  2. On "Get Started": Checked the "Enable Keyman as system-wide keyboard" and set the "keyboard as the default keyboard" box.
  3. Go to Keyman Settings --> Installed Languages --> English -->
  4. On the "English Settings" menu.
  5. Verified that the "Predictions with corrections" radio button is enabled by default.
  6. Verified that the "EuroLation(SIL)" keyboard is installed as default.
  7. Verified that the "Predictions with auto-corrections" radio button does not display.
  8. Checked the radio button to "Disable suggestions" and exit the settings menus.
  9. Return to Keyman's editor app.
  10. Verified the OSK refreshed, and then the Keyman image banner appeared.
  11. Verified that no suggestions appeared. 
    It works well on Android physical & emulator devices. Thank you. 

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Dec 6, 2024
@darcywong00 darcywong00 merged commit 30ed4b8 into master Dec 6, 2024
5 checks passed
@darcywong00 darcywong00 deleted the fix/android/disable-auto-correct branch December 6, 2024 08:53
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.154-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants