Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(developer): scaffolding for Keyman Developer for VSCode🗼 #12799

Merged
merged 5 commits into from
Dec 10, 2024
Merged

feat(developer): scaffolding for Keyman Developer for VSCode🗼 #12799

merged 5 commits into from
Dec 10, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Dec 6, 2024 •
edited
Loading

  • add the VSCode extension directory under developer/src/vscode-plugin : Keyman Developer for VSCode
  • no features yet, just build infrastructure

This will become the parent commit for both #12757 and #12790

@keymanapp-test-bot skip

Fixes: #12798

@srl295 srl295 self-assigned this Dec 6, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Dec 6, 2024 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S16 milestone Dec 6, 2024
@srl295 srl295 changed the base branch from master to epic/ldml-editor December 6, 2024 15:45
@srl295
chore(developer): scaffolding for VSCode plugin
0004467 
- empty plugin
- no building nor LDML editing code

Co-authored-by: Marc Durdin <marc@durdin.net>

Fixes: #12798
@srl295 srl295 force-pushed the feat/developer/12798-vscode-ext-scaffolding-epic-ldml-editor branch from b50eebf to 0004467 Compare December 6, 2024 15:48
@srl295
chore(developer): skip vscode test for now 🗼
5d0a993 
- requires X on linux builder, so skip for now

Fixes: #12798
@srl295 srl295 linked an issue Dec 6, 2024 that may be closed by this pull request
feat(developer): scaffolding for VSCode plugin 🗼 #12798
Open
@srl295
Copy link
Member Author

srl295 commented Dec 6, 2024

Great - test failed on a linux builder without X. I'm stubbing out the vscode-test for now.

09:57:54   > test
09:57:54   > vscode-test
09:57:54   
09:57:54   - Resolving version...
09:57:54   ✔ Validated version: 1.95.3
09:57:54   - Found at https://update.code.visualstudio.com/1.95.3/linux-x64/stable?released=true
09:57:55   ✔ Found at https://update.code.visualstudio.com/1.95.3/linux-x64/stable?released=true
09:57:55   - Downloading (141.50 MB)
09:58:01   ✔ Downloaded VS Code into /var/lib/TeamCity/agent/work/30ffb35c1b6c4089/keyman/developer/src/vscode-plugin/.vscode-test/vscode-linux-x64-1.95.3
09:58:01   No protocol specified
09:58:01   [2747807:1206/105801.627646:ERROR:ozone_platform_x11.cc(245)] Missing X server or $DISPLAY
09:58:01   [2747807:1206/105801.627687:ERROR:env.cc(258)] The platform failed to initialize.  Exiting.
09:58:01   Exit code:   SIGSEGV
09:58:01   npm error Lifecycle script `test` failed with error:
09:58:01   npm error code 1
09:58:01   npm error path /var/lib/TeamCity/agent/work/30ffb35c1b6c4089/keyman/developer/src/vscode-plugin
09:58:01   npm error workspace @keymanapp/developer-vscode
09:58:01   npm error location /var/lib/TeamCity/agent/work/30ffb35c1b6c4089/keyman/developer/src/vscode-plugin
09:58:01   npm error command failed
09:58:01   npm error command sh -c vscode-test
09:58:01   [developer/src/vscode-plugin] ## test failed
09:58:01   [developer/src] ## test:vscode-plugin failed with exit code 1
09:58:01   Process exited with code 1
09:58:01   Process exited with code 1 (Step: [18.0] developer/src/build.sh (Command Line))
09:58:01   Step [18.0] developer/src/build.sh (Command Line) failed

@darcywong00 darcywong00 modified the milestones: A18S16, A18S17 Dec 7, 2024
@srl295 srl295 marked this pull request as ready for review December 9, 2024 14:15
@srl295
Copy link
Member Author

srl295 commented Dec 9, 2024

meant to be ready for review once builds passed.

mcdurdin
mcdurdin approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would be good to check the comments from #12757 as there are a few things that were noted there

developer/src/vscode-plugin/src/test/extension.test.ts Outdated Show resolved Hide resolved
developer/src/vscode-plugin/package.json Outdated Show resolved Hide resolved
@srl295 srl295 merged commit 46e544c into epic/ldml-editor Dec 10, 2024
6 checks passed
@srl295 srl295 deleted the feat/developer/12798-vscode-ext-scaffolding-epic-ldml-editor branch December 10, 2024 17:45
@srl295
Copy link
Member Author

srl295 commented Dec 10, 2024

@mcdurdin double checked all of the comments… all in…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@darcywong00 darcywong00 Awaiting requested review from darcywong00 darcywong00 is a code owner

@SabineSIL SabineSIL Awaiting requested review from SabineSIL SabineSIL is a code owner

@markcsinclair markcsinclair Awaiting requested review from markcsinclair markcsinclair is a code owner

Assignees

@srl295 srl295

Labels
developer/ epic-ldml-editor feat
Projects
Keyman
Status: Done
Milestone
A18S17
Development

Successfully merging this pull request may close these issues.

feat(developer): scaffolding for VSCode plugin 🗼
3 participants
@srl295 @mcdurdin @darcywong00