Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-31 update on window resize and path change #36

Merged
merged 12 commits into from
Jun 14, 2017
Merged

ISSUE-31 update on window resize and path change #36

Changes from 7 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0ba6b6b
Add auto updates to overlay
simonhearne May 22, 2017
4262dee
Used a better variable for interval.
simonhearne May 22, 2017
9e13edb
Linting
simonhearne May 22, 2017
78b7907
Merge branch 'development' into ISSUE-31-event_listeners
simonhearne May 22, 2017
34e1c97
Arrow function for setInterval
simonhearne May 22, 2017
ac7a9c6
Merge branch 'ISSUE-31-event_listeners' of github.com:nccgroup/image-…
simonhearne May 22, 2017
d04d24d
Descriptive variable names.
simonhearne May 22, 2017
4c5b34b
[ISSUE-31][REFACTOR] rename method to increase clarity
tabanliviu May 24, 2017
0bc7e12
[ISSUE-31][TEST] add unit tests for refresh images
tabanliviu May 24, 2017
7d79254
[ISSUE-31][STYLE] remove extra new line
tabanliviu May 24, 2017
94f1df4
[ISSUE-31][FEATURE] use full location href for refresh detection and …
tabanliviu Jun 13, 2017
ae749f7
Merge branch 'development' into ISSUE-31-event_listeners
tabanliviu Jun 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions app/public.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
const SVG_URL_REGEX = /\.svg/i;
const SVG_DATA_URI_REGEX = /^data:.*\/svg/i;
const MIN_IMAGE_SIZE = 10;
const CHECKER_INTERVAL_MS = 500;
let refreshImagesInterval;

/**
* Appends an overlay with images details over the whole web page
Expand Down Expand Up @@ -70,13 +72,50 @@
}
}
});
setEventListeners();
}

/**
* Refresh overlay
*/
function refreshImagesInfo() {
hideImagesInfo();
showImagesInfo();
}

/**
* Set event listeners
*/
function setEventListeners() {
let width = window.innerWidth;
let height = window.innerHeight;
let path = window.location.pathname;
let update;

refreshImagesInterval = setInterval(() => {
update = false;
if (window.location.pathname !== path) {
update = true;
path = window.location.pathname;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tabanliviu DoD - This doesn't include changes in the hash (either for traditional hash or non-HTML5 SPAs).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

}
if (window.innerHeight !== height || window.innerWidth !== width) {
update = true;
width = window.innerWidth;
height = window.innerHeight;
}
if (update) {
refreshImagesInfo();
}
}, CHECKER_INTERVAL_MS);
}


/**
* Remove all overlays
*/
function hideImagesInfo() {
nodeListToArray(document.querySelectorAll('.ncc-image-checker-overlay')).map(o => o.remove());
clearInterval(refreshImagesInterval);
}

/**
Expand Down