Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests on CircleCI #115

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Fix integration tests on CircleCI #115

merged 1 commit into from
Jun 4, 2018

Conversation

timleslie
Copy link
Contributor

The new version of Cypress installs its binary application in a global cache

cypress-io/cypress#1300

This causes builds on circleCI to fail, as they cannot find the install on a fresh machine.

This PR updates our config file to put this cache within the node_modules directory so that the package cache mechanism works correctly.

@jesstelford
Copy link
Contributor

The Cypress docs suggest setting ~/.cache as a cache dir on CircleCI: https://docs.cypress.io/guides/guides/continuous-integration.html#CircleCI

      - save_cache:
          paths:
            - node_modules
            - ~/.cache

@dominikwilkowski
Copy link
Contributor

Yeah @jesstelford but to actually keep a cache between installs we need to have it either inside the node_modules folder or create a new cache... Both is viable and this seems not wrong.

@timleslie timleslie changed the title Fix intergration tests on CircleCI Fix integration tests on CircleCI Jun 4, 2018
@jesstelford
Copy link
Contributor

:shipit: 🎉

@timleslie timleslie merged commit 12aa7ec into master Jun 4, 2018
@jesstelford jesstelford mentioned this pull request Jun 4, 2018
@JedWatson JedWatson deleted the bump-circleci-deps branch June 7, 2018 13:04
@JedWatson
Copy link
Member

Quick heads-up @timleslie, remember to delete branches when you merge PRs otherwise they stay around forever and it gets hard to manage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants