[DISCUSS] Replace unique -> isUnique and required -> isRequired #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesstelford
suggested changes
Dec 6, 2018
jesstelford
suggested changes
Dec 6, 2018
|
Shouldn't they be minor bumps since these packages are on |
|
@mitchellhamilton Yeah, they probably could be minors but I think it's probably easier to move into a 1.x.x regime so that we can make full use of the semver levels. |
jesstelford
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the changes discussed in #461. Having this tangible implementation might make it easier to decide whether this is what we want.
Having seen these changes I'm in favour of making the change. Not least of all because we have a function called
unique()which returns the unique values from a list. Spelling the boolean flagisUniquemakes it easier to search for the different cases.