Tidy up examples, and add types #8096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This comment was marked as resolved.
This comment was marked as resolved.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1f33efc:
|
dcousens
force-pushed
the
examples-tidy
branch
from
97c920f
to
64dda1d
Compare
dcousens
force-pushed
the
examples-tidy
branch
from
e624f68
to
aa1e005
Compare
dcousens
force-pushed
the
examples-tidy
branch
from
7f1840b
to
acb6783
Compare
dcousens
force-pushed
the
examples-tidy
branch
from
acb6783
to
310bca0
Compare
dcousens
force-pushed
the
examples-tidy
branch
2 times, most recently
from
d622afd
to
77295b0
Compare
dcousens
force-pushed
the
examples-tidy
branch
from
77295b0
to
9217a67
Compare
dcousens
force-pushed
the
examples-tidy
branch
from
d3f7990
to
48fc733
Compare
borisno2
reviewed
Feb 6, 2023
dcousens
commented
Feb 6, 2023
| export const lists: Lists = { | ||
| User: list({ | ||
| access: { | ||
| operation: { | ||
| ...allOperations(allowAll), | ||
| // Only allow admins to delete users |
There was a problem hiding this comment.
Probably the example should have prevented other operations too
dcousens
force-pushed
the
examples-tidy
branch
from
cc51d04
to
4697fb4
Compare
dcousens
force-pushed
the
examples-tidy
branch
from
acdb77c
to
6c97757
Compare
Co-authored-by: Josh Calder <josh.calder@thinkmill.com.au>
dcousens
force-pushed
the
examples-tidy
branch
from
715211f
to
2974eb7
Compare
borisno2
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples are, honestly, disorganized and incomplete.
We actively need examples that show-case how to structure your project, and examples that demonstrate and explain the complexity of different features. Some examples might show how a particular use-case might play out, that is OK, but they should be identifiably different from our feature examples.
Before this pull request, our access control and authentication examples did not showcase things like
isFilterableorisOrderable, nor did they showcasefilteroritemaccess control.As of this pull request, many of our examples still need plenty of work, but they are an improvement on what we had.