Fix data proxy unsupported before exit event #8274
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 799fe84:
|
mmachatschek
changed the title
| }); | ||
|
|
||
| // beforeExit event is not supported by Prisma Data Proxy | ||
| if (!prismaClient._dataProxy) { |
There was a problem hiding this comment.
I'm accessing the internal variable prismaClient._dataProxy here because the only alternative to check for dataProxy usage would be:
prismaClient.getEngine().constructor.name === 'DataProxyEngine'
| // to ensure that the process is cleaned up appropriately. | ||
| prismaClient._engine.child?.kill('SIGINT'); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Do we actually need this still?
There was a problem hiding this comment.
I am unable to replicate the original issue (#5477) if I remove this whole prismaClient.$on block
|
Moved changes over to #8347 - Closing the PR... thanks @mmachatschek |
This is based on the branch of PR #7964 as I tested all prisma versions from 4.3.1 (current keystone supported version) to 4.9.0. Earlier versions had problems with parsing the
prisma://database urls