Reduce Nexus example to define extension inline #8375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a211c87:
|
dcousens
force-pushed
the
nexus-less
branch
2 times, most recently
from
45c05c5
to
dd9c0f2
Compare
dcousens
commented
Mar 6, 2023
| t.string('status'); | ||
| t.string('content'); | ||
| }, | ||
| }); |
There was a problem hiding this comment.
This wasn't actually required, we needed to use graphql-nexus/nexus#983
dcousens
commented
Mar 6, 2023
| NexusThingQuery, | ||
| }, | ||
| }); | ||
| } |
There was a problem hiding this comment.
I think this updated example is equivalent in fidelity to our extend-graphql-schema-graphql-ts example?
dcousens
commented
Mar 6, 2023
| @@ -40,18 +40,20 @@ export function extendGraphqlSchema(baseSchema: GraphQLSchema) { | |||
| t.field('nexusPosts', { | |||
| type: nexus.nonNull(nexus.list('Post')), | |||
| args: { | |||
| authorId: nexus.stringArg(), | |||
| id: nexus.nonNull(nexus.stringArg()), | |||
There was a problem hiding this comment.
This is inline with our other examples
dcousens
commented
Mar 6, 2023
| }, | ||
| contextType: { | ||
| module: path.join(process.cwd(), 'node_modules', '.keystone', 'types.d.ts'), | ||
| export: 'Context', |
There was a problem hiding this comment.
I don't know if I prefer this to context: Context, but, it's how nexus works
dcousens
requested review from
borisno2
and removed request for
JedWatson and
emmatown
borisno2
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reduces the complexity of the Nexus example to something that would be more canonically written as an
extendGraphqlSchemafunction.This format is inline with how we are using
extendGraphqlSchemain extend-graphql-schema-graphql-ts and extend-graphql-schema-graphql-tools.This is a followup to #6792