Adds {list}.hooks.validate.[create|update|delete]
hooks
#9056
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds
hooks.validate.create
,hooks.validate.update
andhooks.validate.delete
forlists
.Part of this work is to verify that we are calling these hooks consistently internally, and that the code is easily reviewed.
The existing code was very fragmented, with
mutations/create-update.ts
,mutations/delete.ts
,mutations/validation.ts
,mutations/hooks.ts
andmutations/access-control.ts
each referencing each other for individual parts of functionality.This pull request merges all of that functionality into
mutations/index.ts
, leaving only 1 function inmutations/access-control.ts
to be used by themutations/nested-*
functionality which I have still yet to review.These changes do come with a significant increase in the number of tests for hooks, with
288
tests verifying nearly every combination of hooks I could of think of; with only mixed results needing to be tested from GraphQL.