Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up formatting #9179

Merged
merged 8 commits into from
Jun 24, 2024
Merged

Tidy up formatting #9179

merged 8 commits into from
Jun 24, 2024

Conversation

gautamsi
Copy link
Member

Have tried to cleanup eslint errors which I was trying to fight with vscode, I believe we should nto have dropped the prettier but I have not changed that

not suer if I need to add changeset for this.

Copy link

codesandbox-ci bot commented Jun 23, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 89ce37b:

Sandbox Source
@keystone-6/sandbox Configuration

@dcousens dcousens changed the title cleanup eslint errors Tidy up formatting Jun 23, 2024
@dcousens dcousens force-pushed the eslint-cleanup branch 2 times, most recently from f905a76 to 2e70b99 Compare June 24, 2024 00:31
@dcousens dcousens merged commit fa1f36e into keystonejs:main Jun 24, 2024
42 of 43 checks passed
@dcousens
Copy link
Member

Thanks for this @gautamsi, interested in why a few of them were missed by previous --fix changes - in any event, I'm still happy this isn't part of our CI

@dcousens dcousens self-assigned this Jun 24, 2024
@gautamsi gautamsi deleted the eslint-cleanup branch June 24, 2024 01:06
@dcousens dcousens mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants