Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to Keystone Enterprise #9320

Merged
merged 11 commits into from
Sep 3, 2024
Merged

Update link to Keystone Enterprise #9320

merged 11 commits into from
Sep 3, 2024

Conversation

benderham
Copy link
Contributor

Updates the Main and Footer Navigation to include an external link to the new Keystone Enterprise page on the Thinkmill website.

Also updates the LinkItem to accept a rel and target.

Copy link

codesandbox-ci bot commented Sep 2, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

import Link from 'next/link'
import { type HTMLAttributes } from 'react'
import Link from 'next/link';
import { type HTMLAttributes } from 'react';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the formatting rule is not to use semi

@@ -13,7 +12,7 @@ import { Emoji } from './primitives/Emoji'
import { Type } from './primitives/Type'
import { Socials } from './Socials'

function List (props: HTMLAttributes<HTMLElement>) {
function List(props: HTMLAttributes<HTMLElement>) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function List(props: HTMLAttributes<HTMLElement>) {
function List (props: HTMLAttributes<HTMLElement>) {

@@ -33,7 +32,7 @@ function List (props: HTMLAttributes<HTMLElement>) {
)
}

export function Footer () {
export function Footer() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export function Footer() {
export function Footer () {

docs/components/Header.tsx Outdated Show resolved Hide resolved
docs/components/Header.tsx Outdated Show resolved Hide resolved
docs/components/Header.tsx Outdated Show resolved Hide resolved
@dcousens dcousens merged commit 7808e7d into main Sep 3, 2024
1 check was pending
@dcousens dcousens deleted the keystone-enterprise-link branch September 3, 2024 03:08
relusion added a commit to relusion/keystone that referenced this pull request Sep 8, 2024
- Remove unused code and imports in backend files
- Add bootstrap v5.3.3 as a frontend dependency
- Update package-lock.json and package.json
- Update App.js to import bootstrap CSS
- Improve loading state in App.js
- Add error handling and fetch posts functionality in App.js
- Add addNewPost functionality in App.js
- Update UI in App.js to display user information and posts

Related to keystonejs#9322, keystonejs#9320, keystonejs#9262
@dcousens dcousens mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants