Skip to content

Commit

Permalink
hack: Downgrade ES target to handle bug in library
Browse files Browse the repository at this point in the history 
See voxpelli/pony-cause#35
pony-cause is used by Umzug, so yeah, until that's resolved ES2022 is off limits.
  • Loading branch information
@kf6kjg
kf6kjg committed Jun 3, 2022
1 parent 11c622b commit 8625de7
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tsconfig.base.json
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"compilerOptions": {
/* Basic Options */
"target": "ES2022" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */,
"target": "ES2021" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */,
// Can't use ES2022 with Umzug until either the latter doesn't use pony-cause any more or https://github.com/voxpelli/pony-cause/issues/35 is resolved.
"module": "ESNext" /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */,
// "lib": [ /* Specify library files to be included in the compilation. */
// ],
Expand Down

5 comments on commit 8625de7

@voxpelli
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: Its not a bug in the library, its a bug in TS itself: microsoft/TypeScript#48098

@kf6kjg
Copy link
Owner Author

@kf6kjg kf6kjg commented on 8625de7 Jun 23, 2022 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@voxpelli
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kf6kjg Me and @ljharb both were active in the creation of the spec and our two libraries are the ones linked to from the proposal. I think it would be fair to say that the two of us have an accurate interpretation of the spec :)

@kf6kjg
Copy link
Owner Author

@kf6kjg kf6kjg commented on 8625de7 Jul 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, then yeah, TS got it wrong. :)
[EDIT: I see that a TS Fix is in the works pending a CLA kerfuffle that's being resolved. Excellent.]

@ljharb
Copy link

@ljharb ljharb commented on 8625de7 Jul 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"TS got it wrong", fwiw, is almost always what's happening, and is the appropriate default assumption.

Please sign in to comment.