repo webhook url is sensitive (integrations#540)

* repo webhook url is sensitive * document the reason for marking url sensitive Co-authored-by: kzw <kzw@noreply.github.com>
kfcampbell · Nov 5, 2020 · 46d338a · 46d338a
1 parent a29cf42
commit 46d338a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/github/schema_webhook_configuration.go b/github/schema_webhook_configuration.go
@@ -12,8 +12,9 @@ func webhookConfigurationSchema() *schema.Schema {
 		Elem: &schema.Resource{
 			Schema: map[string]*schema.Schema{
 				"url": {
-					Type:     schema.TypeString,
-					Required: true,
+					Type:      schema.TypeString,
+					Required:  true,
+					Sensitive: true,
 				},
 				"content_type": {
 					Type:     schema.TypeString,

diff --git a/website/docs/r/repository_webhook.html.markdown b/website/docs/r/repository_webhook.html.markdown
@@ -56,7 +56,7 @@ The following arguments are supported:
 
 The following additional attributes are exported:
 
-* `url` - URL of the webhook
+* `url` - URL of the webhook.  This is a sensitive attribute because it may include basic auth credentials.
 
 ## Import
 
@@ -69,4 +69,4 @@ Importing uses the name of the repository, as well as the ID of the webhook, e.g
 $ terraform import github_repository_webhook.terraform terraform/11235813
 ```
 
-If secret is populated in the webhook's configuration, the value will be imported as "********".
+If secret is populated in the webhook's configuration, the value will be imported as "********".