Skip to content

Commit

Permalink
remove ForceNew on template* as they are concerns only at creatio…
Browse files Browse the repository at this point in the history
…n time (integrations#609)

There are a number of resources that have been marked as `ForceNew: true` out of a desire in "correctness" by those that do not actually understand how these resources are used in the real world and damage that can be done. No one wants to blow up a repository to change something like this, if they need to there is a mechanism built into terraform called [taint](https://www.terraform.io/docs/commands/taint.html). While there are some things that make sense for using `ForceNew` a repository for source control on properties that the API will ignore outside of creation is not one of them.

Signed-off-by: Ben Abrams <me@benabrams.it>
  • Loading branch information
majormoses authored Dec 18, 2020
1 parent 5370a44 commit c73564e
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions github/resource_github_repository.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,13 +106,11 @@ func resourceGithubRepository() *schema.Resource {
},
"license_template": {
Type: schema.TypeString,
Optional: true,
ForceNew: true,
Optional: true
},
"gitignore_template": {
Type: schema.TypeString,
Optional: true,
ForceNew: true,
},
"archived": {
Type: schema.TypeBool,
Expand Down Expand Up @@ -167,7 +165,6 @@ func resourceGithubRepository() *schema.Resource {
"template": {
Type: schema.TypeList,
Optional: true,
ForceNew: true,
MaxItems: 1,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
Expand Down

0 comments on commit c73564e

Please sign in to comment.