Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest version of NetInfo module #193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

julitroalves
Copy link

Added some fixes to support latest version of @react-native-community/netinfo
Updates:

  • Fix undefined property from NetInfo.isConnect;
  • update handleConnectivityChange callback;
  • added unsubscribable to remove listener at componentWillUnmount;

Added some fixes to support latest version of @react-native-community/netinfo
Updates:
- Fix undefined property from NetInfo.isConnect;
- update handleConnectivityChange callback;
- added unsubscribable to remove listener at componentWillUnmount;
@akunal1
Copy link

akunal1 commented Jan 20, 2021

Please update package.json with @react-native-community/netinfo

@@ -12,11 +12,12 @@ const flattenStyle = ReactNative.StyleSheet.flatten;

const ImageCacheManager = require('./ImageCacheManager');

const NetInfo = require('@react-native-community/netinfo');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update package.json for the same pls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants