INCR transfer bug fixes #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The target should be copied from that given in SelectionRequest, not set
to INCR. This fixes a bug where it was impossible to paste > 4000
characters of text from xsel to the Chromium browser. Note that some
programs, including Chromium, validate the 'target' that is passed back;
while other programs, such as those which use the GTK clipboard API,
ignore it. But based the ICCCM, it appears that xsel is incorrect, not
chromium:
"The owner should set the specified selection, target, time, and
propety arguments to the values received in the SelectionRequest event."
This fixes a bug where xsel would only output the first 3999 characters of the selection.
|
@ebiggers I am not sure this patch will be merged, but I need this featue in neovim. as the issue opened here |
|
@kfish can you comment? |
|
In Arch Linux, the following script can mitigate the bug ( community/xsel-1.2.0-6 ) # zsh
xxd =xsel | sed -r 's/(00003930: .*)0f 8f9a 0000 00/\19090 9090 9090/' | xxd -r > /tmp/x && sudo cp /tmp/x =xsel |
7 tasks
cstrahan
added a commit
to cstrahan/nixpkgs
that referenced
this pull request
Sep 21, 2016
The last xsel release was in 2008. Since then, a number of bugs have been fixed. For example, pasting a large chunk of text (>4000 chars) into chrome would cause the current tab to hang indefinitely. A couple examples in the wild: kfish/xsel#14 kfish/xsel#13 kfish/xsel#16 https://bugs.chromium.org/p/chromium/issues/detail?id=515401 electron/electron#3116 neovim/neovim#4719
acowley
pushed a commit
to acowley/nixpkgs
that referenced
this pull request
Sep 29, 2016
The last xsel release was in 2008. Since then, a number of bugs have been fixed. For example, pasting a large chunk of text (>4000 chars) into chrome would cause the current tab to hang indefinitely. A couple examples in the wild: kfish/xsel#14 kfish/xsel#13 kfish/xsel#16 https://bugs.chromium.org/p/chromium/issues/detail?id=515401 electron/electron#3116 neovim/neovim#4719
|
Thank you for fixing this, @ebiggers . |
Closed
L-P
added a commit
to L-P/dotfiles
that referenced
this pull request
Oct 23, 2018
Mitigate bug in xclip by not using xclip https://bugs.chromium.org/p/chromium/issues/detail?id=515401 kfish/xsel#16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.