Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price Points? #52

Closed
MartyIce opened this issue Aug 10, 2017 · 13 comments
Closed

Price Points? #52

MartyIce opened this issue Aug 10, 2017 · 13 comments

Comments

@MartyIce
Copy link

Are Price Points updatable with the API? I searched code for "price_point_id" and "PricePoint", but didn't get any hits.

If not, are there any plans to add in near future?

Thanks!

@kfrancis
Copy link
Owner

Can add this for you if you need.

@praveen-prakash
Copy link

Yes Please do. :) I also have to implement the same in my app.

@vgooz
Copy link

vgooz commented Jun 12, 2018

When are you planing to add price points support?
I need this feature too. Thanks.

@kfrancis
Copy link
Owner

kfrancis commented Jul 4, 2018

Happy to take PRs here

@asfmadx
Copy link

asfmadx commented Jul 20, 2020

Is this going to be implemented?

@danduyser
Copy link

Any chance @EdLichtman wants to tackle this one? :)

@EdLichtman
Copy link
Contributor

Haven't worked in here in a while and I definitely don't have a dev environment set up or dev credentials.

I'd be interested in trying to help, but I'd like to take some time to figure out automated tests.

@kfrancis
Copy link
Owner

kfrancis commented Oct 8, 2021

Sorry, I've been a bit busy lately. If you can't @EdLichtman, just let me know.

@EdLichtman
Copy link
Contributor

Hiya Kori,

I'm going to see what I can do about it over the next few weeks. I would be interested in pair programming if you'd like, since I would like to more pleasantly fit your pre-existing patterns (sorry for the outlier designed code I had previously written)

@EdLichtman
Copy link
Contributor

Honestly @kfrancis I don't think I'll get it done. Things have been packed. If in a week from now you still haven't gotten it done, I'll see about trying it out, but I won't start working on it unless I come back and tell you I'm doing it. I don't want to stop you from delivering value to the people who rely on your library.

@kfrancis
Copy link
Owner

kfrancis commented Nov 2, 2021

Well, I remember now why I didn't add it immediately. Kind of annoying to implement, especially if I want to keep XML format alive in there as well. Working on it.

@kfrancis
Copy link
Owner

kfrancis commented Nov 2, 2021

#89

kfrancis added a commit that referenced this issue Nov 3, 2021
@kfrancis
Copy link
Owner

kfrancis commented Nov 3, 2021

See release v1.4.0.

Now, not all methods are currently implemented. I've found that this set of endpoints is rather fickle between json and XML. I'm still working on getting more information from Chargify, at which time I'll release an update.

@kfrancis kfrancis closed this as completed Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants