Bug Fix:75 UpdateDelayedCancellation not working #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleans up some tests;
Addition of Functional behavior to begin refactoring with DRY
Gets My fork up to date
Feature 67
Feature 63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of Functional behavior to begin refactoring with DRY
@kfrancis I noticed there's tons of try/catch/throw specific exceptions so I added the new ExceptionHandler in a functional manner to try and abstract the idea of "what is this class doing". I understand it's a new way of doing things, so let me know if you need me to rewrite any of it to match the rest of the solution, but I think it would be a good thing to start working in as cleanup.
Cheers,
Eddie