Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes issue #38 #39

Merged
merged 2 commits into from
Sep 17, 2024
Merged

fixes issue #38 #39

merged 2 commits into from
Sep 17, 2024

Conversation

elsdvlee
Copy link
Collaborator

What's changed

Replaced sh:name and sh:description by rdfs:label and rdfs:comment

Change checklist

  • updated ontology, where necessary
  • updated shapes, where necessary
  • added or updated test cases, where necessary
  • any TODOs have been turned into trackable issues and referenced where necessary

Issue reference

Fixes #38

@elsdvlee elsdvlee requested a review from pmaria August 21, 2024 14:07
pmaria
pmaria requested changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@pmaria pmaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elsdvlee de changes should only be made on the NodeShape level. The property shapes can be left as is

@elsdvlee elsdvlee merged commit a490799 into main Sep 17, 2024
1 check failed
@elsdvlee elsdvlee deleted the issue_38 branch September 17, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmaria pmaria pmaria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace sh:name and sh:description in SHACL shapes
2 participants
@elsdvlee @pmaria