Skip to content

Commit

Permalink
Makefile: Remove security scan targets
Browse files Browse the repository at this point in the history
This commit rips out the security scan related
Makefile targets. The docs/cmd/generate_docs.go file
no longer exists in the repository after #10576 merged
to main.

Additionally, the scan-version target no longer works
as the github.com/solo-io/go-utils/securityscanutils/cli
tool hangs when scanning the kgateway images.

Signed-off-by: timflannagan <timflannagan@gmail.com>
  • Loading branch information
timflannagan committed Feb 5, 2025
1 parent 6c31612 commit 8ed3095
Showing 1 changed file with 0 additions and 31 deletions.
31 changes: 0 additions & 31 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -713,37 +713,6 @@ conformance-%: $(TEST_ASSET_DIR)/conformance/conformance_test.go
go test -mod=mod -ldflags='$(LDFLAGS)' -tags conformance -test.v $(TEST_ASSET_DIR)/conformance/... -args $(CONFORMANCE_ARGS) \
-run-test=$*

#----------------------------------------------------------------------------------
# Security Scan
#----------------------------------------------------------------------------------
# Locally run the Trivy security scan to generate result report as markdown

SCAN_DIR ?= $(OUTPUT_DIR)/scans
SCAN_BUCKET ?= solo-gloo-security-scans
# The minimum version to scan with trivy
# ON_LTS_UPDATE - bump version
MIN_SCANNED_VERSION ?= v1.15.0

.PHONY: run-security-scans
run-security-scan:
MIN_SCANNED_VERSION=$(MIN_SCANNED_VERSION) GO111MODULE=on go run docs/cmd/generate_docs.go run-security-scan -r gloo -a github-issue-latest
MIN_SCANNED_VERSION=$(MIN_SCANNED_VERSION) GO111MODULE=on go run docs/cmd/generate_docs.go run-security-scan -r glooe -a github-issue-latest

.PHONY: publish-security-scan
publish-security-scan:
# These directories are generated by the generated_docs.go script. They contain scan results for each image for each version
# of gloo and gloo enterprise. Do NOT change these directories without changing the corresponding output directories in
# generate_docs.go
gsutil cp -r $(SCAN_DIR)/gloo/markdown_results/** gs://$(SCAN_BUCKET)/gloo
gsutil cp -r $(SCAN_DIR)/solo-projects/markdown_results/** gs://$(SCAN_BUCKET)/solo-projects

.PHONY: scan-version
scan-version: ## Scan all Gloo images with the tag matching {VERSION} env variable
PATH=$(DEPSGOBIN):$$PATH GO111MODULE=on go run github.com/solo-io/go-utils/securityscanutils/cli scan-version -v \
-r $(IMAGE_REGISTRY)\
-t $(VERSION)\
--images kgateway,envoy-wrapper,sds

#----------------------------------------------------------------------------------
# Third Party License Management
#----------------------------------------------------------------------------------
Expand Down

0 comments on commit 8ed3095

Please sign in to comment.