Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: Re-organize dependencies #10560

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

timflannagan
Copy link
Member

@timflannagan timflannagan commented Jan 30, 2025

Description

This PR re-organizes the root go.mod. Previously, the first require directive had a mix of direct and indirect dependencies, which is a surprising organization for Go-based projects. Now, those indirect dependencies have been moved to the same require directive with the rest of the indirect dependencies.

Additionally, there were two require directives for the direct dependencies. While this isn't a big issue, there didn't seem to be a reason or theme that explains why these dependencies were separated.

Related to #10496.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Signed-off-by: timflannagan <timflannagan@gmail.com>
Signed-off-by: timflannagan <timflannagan@gmail.com>
@jenshu jenshu added this pull request to the merge queue Jan 30, 2025
Merged via the queue into kgateway-dev:main with commit 1e88bf3 Jan 30, 2025
8 checks passed
@timflannagan timflannagan deleted the chore/go-mod-move-indirects branch January 31, 2025 01:18
tiberiuac pushed a commit to openet/gloo that referenced this pull request Feb 13, 2025
Co-authored-by: changelog-bot <changelog-bot>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants