*: Flatten repository structure #10583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Base layer moving all project code to internal - Keeps original structure intact within internal/ Signed-off-by: timflannagan <timflannagan@gmail.com>
- Flattens API types to root level - Standard location for Kubernetes API types Signed-off-by: timflannagan <timflannagan@gmail.com>
- Consolidates all binaries under cmd/ - Standard Go project layout for executables Signed-off-by: timflannagan <timflannagan@gmail.com>
- Cleanup of specific binary location - Part of cmd/ directory standardization Signed-off-by: timflannagan <timflannagan@gmail.com>
- Updates docs, configs, and other non-Go files - Includes GHA workflows, goreleaser config, etc. Signed-off-by: timflannagan <timflannagan@gmail.com>
- Updates Go imports to reflect new structure - Single atomic change for all import updates Signed-off-by: timflannagan <timflannagan@gmail.com>
- Moves codegen tooling to standard location - Updates paths in generation scripts Signed-off-by: timflannagan <timflannagan@gmail.com>
- Updates codegen scripts for new paths - Ensures generated code works with new structure Signed-off-by: timflannagan <timflannagan@gmail.com>
- Final regeneration of client code - Verifies all paths are correct Signed-off-by: timflannagan <timflannagan@gmail.com>
timflannagan
force-pushed
the
feat/deflate
branch
from
83128ac to
3924579
Compare
4 tasks
jenshu
approved these changes
Feb 6, 2025
Comment on lines
+12
to
+13
| v1 "github.com/kgateway-dev/kgateway/internal/gateway/pkg/api/v1" | ||
| gloov1 "github.com/kgateway-dev/kgateway/internal/gloo/pkg/api/v1" |
There was a problem hiding this comment.
nit: these directories don't exist and probably don't need to be updated in this PR, but i don't feel strongly since these tests don't currently get compiled and will be ripped out eventually
| @@ -301,7 +301,7 @@ generated-code: fmt | |||
|
|
|||
| .PHONY: go-generate-all | |||
| go-generate-all: ## Run all go generate directives in the repo, including codegen for protos, mockgen, and more | |||
| GO111MODULE=on go generate ./projects/gateway2/... | |||
| GO111MODULE=on go generate ./hack/... | |||
There was a problem hiding this comment.
there was also a go:generate in internal/gateway2/query/query_test.go for generating mocks - do we need to call that here too?
timflannagan
commented
Feb 6, 2025
| @@ -11,9 +11,9 @@ env: | |||
| GITHUB_TOKEN: ${{ github.token }} | |||
|
|
|||
| jobs: | |||
| # Runs the unit tests for `projects/gateway2` | |||
| # Runs the unit tests for `internal/gateway2` | |||
There was a problem hiding this comment.
We're planning on renaming this directory in a follow-up. Similarly, we may need to pull out some internal// files into pkg for external consumption in a follow-up.
The projects/gateway2 is a required job and changing the name will require changes to our GH settings. We can handle this in a follow-up to help unblock this stream of work. Signed-off-by: timflannagan <timflannagan@gmail.com>
jenshu
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements #10566.
Checklist: