Skip to content
This repository has been archived by the owner on Mar 7, 2019. It is now read-only.

Image Previews of Fieldsets #374

Closed
Nicholas-Westby opened this issue Jul 27, 2016 · 7 comments
Closed

Image Previews of Fieldsets #374

Nicholas-Westby opened this issue Jul 27, 2016 · 7 comments
Assignees

Comments

@Nicholas-Westby
Copy link
Contributor

When a content editor adds an Archetype fieldset to a property, this is the selection dialog they see:

add

They have no idea that a "Link Sidebar Callouts" looks like this:

links

Would be really useful if there were a "See Example" link next to that "Link Sidebar Callout" that, when clicked, showed the above screenshot.

So, the request is to be able to associate each Archetype fieldset with an image so content editors can have a better idea of what it looks like when they are constructing pages. I'd recommend presenting it as a link rather than displaying it inline, as displaying it inline would look a bit weird (assuming some of the screenshots would be very large).

It might looks something like this:

see-example

Clicking that could just open the image in a new window, or could open it in a lightbox.

@kjac
Copy link
Contributor

kjac commented Jun 7, 2017

@Nicholas-Westby I like this idea a lot. It shouldn't be too hard to do, if we can make do with configuring relative paths on the server for each applicable fieldset, so we don't have to muck about with uploading files on the config page.

@Nicholas-Westby
Copy link
Contributor Author

@kjac Configuring a path works for me. If we go with the simple option of opening the image in a new window, I can probably submit a pull request in the next few weeks (unless you want to tackle it before then).

@kjac
Copy link
Contributor

kjac commented Jun 9, 2017

@Nicholas-Westby I'll come up with something this weekend and run it past you.

@kjac
Copy link
Contributor

kjac commented Jun 9, 2017

@Nicholas-Westby how about something like this?

archetype fieldset preview

@Nicholas-Westby
Copy link
Contributor Author

That looks fantastic! Might be somewhat problematic for widgets that are wide (I'm assuming that's doing max-width: 100%;), but beyond that minor nitpick this looks like a huge improvement for usability when using Archetype for widgets.

One idea for improving the ability to view wide images would be to have a link in the image view that says "(open in new window)".

@kjac
Copy link
Contributor

kjac commented Jun 10, 2017

@Nicholas-Westby I've added a zoom icon when hovering the image, and wrapped the image in a link that opens in a new window.

Looks something like this:

archetype fieldset preview 2

kjac pushed a commit to kjac/Archetype that referenced this issue Jun 11, 2017
@kjac kjac self-assigned this Jun 11, 2017
@kjac
Copy link
Contributor

kjac commented Jun 13, 2017

Fixed in v1.14.1

@kjac kjac closed this as completed Jun 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants