Skip to content
This repository has been archived by the owner on Mar 7, 2019. It is now read-only.

Files are still disappearing in image cropper and file upload #389

Closed
kjac opened this issue Feb 24, 2017 · 4 comments
Closed

Files are still disappearing in image cropper and file upload #389

kjac opened this issue Feb 24, 2017 · 4 comments
Assignees

Comments

@kjac
Copy link
Contributor

kjac commented Feb 24, 2017

The fix for #384 needs to be extended a bit. It works for regularly named files, but as soon as you start adding special chars like @ to the file names, it doesn't work any longer.

I'll have to look into the sanitizing of file names that's going on on the Umbraco side of things, and either piggybag on it or replicate it within Archetype.

@kjac kjac self-assigned this Feb 24, 2017
@mortenholmgaard
Copy link

And it does not work with spaces either.

@DanDiplo
Copy link

Yes, probably the biggest issue is that it fails silently if the filename has a space in it, which is quite common for image filenames on Windows.

kjac pushed a commit to kjac/Archetype that referenced this issue Jun 6, 2017
@kjac
Copy link
Contributor Author

kjac commented Jun 7, 2017

#400 fixes this issue for Umbraco versions below 7.6.

@kjac
Copy link
Contributor Author

kjac commented Jun 13, 2017

Fixed in v1.14.1

@kjac kjac closed this as completed Jun 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants