-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement skins search #274
base: master
Are you sure you want to change the base?
Conversation
@samyycX thank you very much, I will be testing this version of yours in the branch I use. Any problems report here, thanks again. [UPDATE] |
@samyycX thanks, I'll be testing everything now and come back here. Thanks. |
Sorry but im not very familiar with git.. Since you have code for PR 271 in your repository, should I commit the code in your repository from now on? Because if I continue to commit the code in my repository, it will be a problem for you to merge |
@samyycX my version is now going, I took the liberty of adding the Portuguese-BR translation in my branch. I believe so, must confirm in my repository. So both your changes and the one in PR #271 take effect if @kgns merges after checking everything. The only difference between my branch and yours is that I added access to the [UPDATE] Thanks again, if I get any errors let me know here. |
Sure, my code is basically complete, the only problem is that I haven't make |
@samyycX I understand, thank you. In any case, I saw your PR #274 and #271, both can be merged later without problems, as you mentioned before too, individually. From what I've seen, they won't generate conflicts if they merge first with 271 and then with 274. My version in this case would be the same as them, but as I mentioned, with VIP access in the And again, thank you! |
Ok, I will wait for PR #271 to be merged and then make some compatibility changes in this PR afterwards. |
For #273, @crashzk
This code can enable player to search skins.
Usage
!ws <skin name>
to searchlike
!ws asi
and it will show a menu like this:
then it will show a menu like this:
Options
SearchApplyCurrentFailed
phrase.some skins, like Asiimov, has different skin id for different weapons ( 801 for AK47, 551 for P250)
this option can apply the skin id you selected to the weapon in your hand (even if the weapon doesn't originally have this skin)
the reason i designed it like this because i think this will be more fun and useful ( because player can just hold the specified weapon in their hand and click 'Apply current' option instead of setting with this option)
Translation Phrase
TODO
since #271 add a cvar
sm_weapons_enable_all_skins
, we need to do a check before player use the specified weapon options ( or just disable all the specified weapon options )